Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lastupdated filter 90 #100

Merged
merged 6 commits into from
Nov 15, 2024
Merged

Lastupdated filter 90 #100

merged 6 commits into from
Nov 15, 2024

Conversation

lincmba
Copy link
Contributor

@lincmba lincmba commented Nov 8, 2024

IMPORTANT: Where possible all PRs must be linked to a Github issue

fixes #90

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for
    bug fixes
  • I have added documentation for any new feature(s) and configuration
    option(s) on the README.md
  • I have run mvn spotless:check to check my code follows the project's
    style guide
  • I have run mvn clean test jacoco:report to confirm the coverage report
    was generated at plugins/target/site/jacoco/index.html
  • I ran mvn clean package right before creating this pull request.

@lincmba lincmba mentioned this pull request Nov 8, 2024
5 tasks
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 75.60976% with 10 lines in your changes missing coverage. Please review.

Project coverage is 60.24%. Comparing base (b615556) to head (ada1ddd).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
...teway/plugins/LocationHierarchyEndpointHelper.java 77.50% 4 Missing and 5 partials ⚠️
...way/plugins/PractitionerDetailsEndpointHelper.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #100      +/-   ##
============================================
+ Coverage     60.15%   60.24%   +0.08%     
- Complexity      193      201       +8     
============================================
  Files            16       16              
  Lines          1403     1401       -2     
  Branches        158      161       +3     
============================================
  Hits            844      844              
+ Misses          478      476       -2     
  Partials         81       81              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lincmba lincmba requested a review from ndegwamartin November 8, 2024 09:06
Copy link
Member

@dubdabasoduba dubdabasoduba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lincmba Please update the versions where necessary so we can deploy for testing

@lincmba lincmba force-pushed the lastupdated_filter_90 branch from ee1bbce to 1cccb3d Compare November 12, 2024 07:43
@pld
Copy link
Member

pld commented Nov 15, 2024

@dubdabasoduba is this good to go now?

@pld pld merged commit d952d39 into main Nov 15, 2024
3 checks passed
@pld pld deleted the lastupdated_filter_90 branch November 15, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the LocationHierarchy endpoint to filter locations by _lastUpdated when on list mode
3 participants