Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Location Hierarchy endpoint lineage ids enhancement and refactor #114

Closed
wants to merge 335 commits into from

Conversation

ndegwamartin
Copy link
Collaborator

@ndegwamartin ndegwamartin commented Jan 21, 2025

IMPORTANT: Where possible all PRs must be linked to a Github issue

Resolves #112
Resolves #113

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for
    bug fixes
  • I have added documentation for any new feature(s) and configuration
    option(s) on the README.md
  • I have run mvn spotless:check to check my code follows the project's
    style guide
  • I have run mvn clean test jacoco:report to confirm the coverage report
    was generated at plugins/target/site/jacoco/index.html
  • I ran mvn clean package right before creating this pull request.

dubdabasoduba and others added 30 commits November 30, 2023 16:17
🐛 Fix the resource ID reference fetch when creating sync tags
Support custom sync filter tag urls through env variables
Update Sync Filter Ignored config - add more resources
 - Add README documentation
 - Move Magic Strings to constants file
 - Add functionality to a separate use case of when `/List?_id` is used
 - Update Tests with these changes
Make self link consistent with other pagination links
Add support for pagination of list entries
 - User selected sync strategy
 - User selected sync strategy
 fixes opensrp/fhircore#3052
@ndegwamartin ndegwamartin force-pushed the lineage-opt branch 2 times, most recently from 9203217 to 79942b6 Compare January 28, 2025 08:27
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 49.61240% with 65 lines in your changes missing coverage. Please review.

Project coverage is 62.21%. Comparing base (78290cf) to head (451d081).

Files with missing lines Patch % Lines
...teway/plugins/LocationHierarchyEndpointHelper.java 65.26% 26 Missing and 7 partials ⚠️
.../fhir/gateway/plugins/PermissionAccessChecker.java 0.00% 32 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #114      +/-   ##
============================================
- Coverage     62.96%   62.21%   -0.75%     
- Complexity      221      229       +8     
============================================
  Files            16       16              
  Lines          1477     1588     +111     
  Branches        168      194      +26     
============================================
+ Hits            930      988      +58     
- Misses          460      504      +44     
- Partials         87       96       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ndegwamartin ndegwamartin marked this pull request as ready for review January 28, 2025 13:49
@ndegwamartin
Copy link
Collaborator Author

@pld @dubdabasoduba for the backward compatibility flag, our default check is for true if the query parameter exists and its value to true. However cant help wondering if it should be an OR there, i.e. filter_mode_lineage Defined or true, since the addition of the query parameter indicates intention to enable this mode.

@pld
Copy link
Member

pld commented Jan 28, 2025

Yea I agree that makes more sense, if it's not passed it is false, if it passed it is true, regardless of what its value

@ndegwamartin ndegwamartin force-pushed the lineage-opt branch 2 times, most recently from 8c83013 to 451d081 Compare January 29, 2025 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
9 participants