Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Populate user assignements into PractitionerDetails contained field #115

Merged
merged 10 commits into from
Jan 29, 2025

Conversation

Rkareko
Copy link
Collaborator

@Rkareko Rkareko commented Jan 23, 2025

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #109

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for
    bug fixes
  • I have added documentation for any new feature(s) and configuration
    option(s) on the README.md
  • I have run mvn spotless:check to check my code follows the project's
    style guide
  • I have run mvn clean test jacoco:report to confirm the coverage report
    was generated at plugins/target/site/jacoco/index.html
  • I ran mvn clean package right before creating this pull request.

@Rkareko Rkareko requested a review from ndegwamartin January 23, 2025 05:44
@Rkareko Rkareko self-assigned this Jan 23, 2025
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.96%. Comparing base (91d6c85) to head (b0cf899).
Report is 11 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #115      +/-   ##
============================================
+ Coverage     62.72%   62.96%   +0.24%     
- Complexity      220      221       +1     
============================================
  Files            16       16              
  Lines          1470     1477       +7     
  Branches        168      168              
============================================
+ Hits            922      930       +8     
  Misses          460      460              
+ Partials         88       87       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Rkareko Rkareko marked this pull request as ready for review January 24, 2025 06:25
@Rkareko Rkareko requested a review from dubdabasoduba January 27, 2025 12:58
@Rkareko Rkareko merged commit 78290cf into main Jan 29, 2025
5 checks passed
@Rkareko Rkareko deleted the 109-practitioner-details-save-all-in-contained branch January 29, 2025 06:31
ndegwamartin pushed a commit that referenced this pull request Jan 29, 2025
…in-contained

Populate user assignements into PractitionerDetails contained field
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Populate user assignements into PractitionerDetails contained field
2 participants