Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sync by Location bug on Main #116

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Fix sync by Location bug on Main #116

merged 1 commit into from
Jan 24, 2025

Conversation

ndegwamartin
Copy link
Collaborator

IMPORTANT: Where possible all PRs must be linked to a Github issue

Resolves [link to issue]

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for
    bug fixes
  • I have added documentation for any new feature(s) and configuration
    option(s) on the README.md
  • I have run mvn spotless:check to check my code follows the project's
    style guide
  • I have run mvn clean test jacoco:report to confirm the coverage report
    was generated at plugins/target/site/jacoco/index.html
  • I ran mvn clean package right before creating this pull request.

@ndegwamartin ndegwamartin merged commit d38a787 into main Jan 24, 2025
1 check passed
@ndegwamartin ndegwamartin deleted the sync-location-hotfix branch January 24, 2025 09:18
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 62.60%. Comparing base (3e4502f) to head (c2c4007).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
.../fhir/gateway/plugins/PermissionAccessChecker.java 0.00% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #116      +/-   ##
============================================
- Coverage     62.92%   62.60%   -0.33%     
+ Complexity      219      218       -1     
============================================
  Files            16       16              
  Lines          1454     1460       +6     
  Branches        166      166              
============================================
- Hits            915      914       -1     
- Misses          452      459       +7     
  Partials         87       87              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ndegwamartin added a commit that referenced this pull request Jan 29, 2025
Fix sync by Location bug on Main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants