Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix the stream close bug caused by the REL fetch check #120

Merged
merged 3 commits into from
Feb 12, 2025

Conversation

dubdabasoduba
Copy link
Member

IMPORTANT: Where possible all PRs must be linked to a Github issue

Resolves [link to issue]

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for
    bug fixes
  • I have added documentation for any new feature(s) and configuration
    option(s) on the README.md
  • I have run mvn spotless:check to check my code follows the project's
    style guide
  • I have run mvn clean test jacoco:report to confirm the coverage report
    was generated at plugins/target/site/jacoco/index.html
  • I ran mvn clean package right before creating this pull request.

Copy link

codecov bot commented Feb 12, 2025

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 63.44%. Comparing base (6fe8901) to head (c943ae1).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...ister/fhir/gateway/plugins/SyncAccessDecision.java 16.66% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #120      +/-   ##
============================================
- Coverage     63.52%   63.44%   -0.08%     
  Complexity      235      235              
============================================
  Files            16       16              
  Lines          1601     1603       +2     
  Branches        199      201       +2     
============================================
  Hits           1017     1017              
- Misses          483      485       +2     
  Partials        101      101              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

import java.util.HashMap;
import java.util.List;
import java.util.Map;
import java.util.*;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the use of wildcard import intentional?

import org.hl7.fhir.r4.model.Location;
import org.hl7.fhir.r4.model.OperationOutcome;
import org.hl7.fhir.r4.model.Resource;
import org.hl7.fhir.r4.model.*;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the use of wildcard import intentional?

@dubdabasoduba dubdabasoduba merged commit ec516bf into main Feb 12, 2025
1 of 3 checks passed
@dubdabasoduba dubdabasoduba deleted the feature/fix_stream_close branch February 12, 2025 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants