Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DNM] FHIR Gateway Enhancements #92

Closed
wants to merge 318 commits into from
Closed

[DNM] FHIR Gateway Enhancements #92

wants to merge 318 commits into from

Conversation

ndegwamartin
Copy link
Collaborator

IMPORTANT: Where possible all PRs must be linked to a Github issue

In this PR

  • Fix REL sync strategy Caching bug
  • Refactor to support returning all paginated results
  • Refactor REL upstream fetch to single request
  • Pagination count bumped to 200
  • Release version 2.1.2

Engineer Checklist

  • I have written Unit tests for any new feature(s) and edge cases for
    bug fixes
  • I have added documentation for any new feature(s) and configuration
    option(s) on the README.md
  • I have run mvn spotless:check to check my code follows the project's
    style guide
  • I have run mvn clean test jacoco:report to confirm the coverage report
    was generated at plugins/target/site/jacoco/index.html
  • I ran mvn clean package right before creating this pull request.

rehammuzzamil and others added 30 commits November 10, 2023 12:47
@rehammuzzamil
Fix spotless issues
4ee0916
@rehammuzzamil
Fix spotless issues
058b71a
@rehammuzzamil
Merge main
578aa09
@rehammuzzamil
Fix spotless issues
87db9b4
@ndegwamartin
Merge pull request #20 from onaio/upgrade-libs
2afda89 
Upgrade HAPI FHIR Client and FHIR Gateway dependencies
@ndegwamartin
Merge branch 'main' into 9-fix-code-coverage
528bdfe
@ndegwamartin
Fix Jacoco Reporting issue
0d0c457 
- Remove Jupiter unit test dependency
@ndegwamartin
Merge pull request #19 from onaio/9-fix-code-coverage
a926293 
Code cleanup and Addressing Test Debt - Adding Unit Tests for Custom Endpoints PractitionerDetails and LocationHierarchy
@ndegwamartin
Various Enhancements and Fixes
1dd853a 
- Bump up version to 1.0.2
- Upgrade FHIR Common Utils version to 1.0.0
- Optimize location fetch
- Fix null pointer for non Resource endpoint permission check
- Migrate practitioner details endpoint to /PractitionerDetail
- Fix InvalidRequestException handling causing interner server error
- Update/Fix Allowed Queries Configuration
- Clean up
@ndegwamartin
Update pull_request_template.md
5f50812
@ndegwamartin
Fix unit tests
2e4e26e
@ndegwamartin
Merge branch 'main' into fix-gateway-plugin
c7a8171
@ndegwamartin
Fix PR template formatting
23f8582
@ndegwamartin
Fix issue PractionerDetails NOT Found fails silently
5916816
@ndegwamartin
Code clean up
1be59c4
@ndegwamartin
Performance optimization
4c89aa3 
- Refactor to optimize location hierarchy endpoint
- Refactor to optimize practitioner details endpoint via cache
- Clean up
@ndegwamartin
Merge pull request #23 from onaio/fix-gateway-plugin
132269f 
Various Enhancements and Fixes
@dubdabasoduba
🐛 Fix the resource ID reference fetch when creating sync tags
0f6ff4b
@allan-on
Update pom.xml
74d9575
@allan-on
Update pom.xml
ed8f367
@allan-on
Update pom.xml
dc9a341
@dubdabasoduba
⬆️ Upgrade the plugins version
c75c330
@dubdabasoduba
Merge pull request #26 from onaio/feature/fix_tags_bug
d78e161 
🐛 Fix the resource ID reference fetch when creating sync tags
@LZRS
Support custom sync filter tag urls through env variables
91fd667
@dubdabasoduba
Merge pull request #30 from onaio/sync_tags_env_vars
9a3d65a 
Support custom sync filter tag urls through env variables
@LZRS
Update to v1.0.4
c03c430
@LZRS
Merge pull request #31 from onaio/update-v1.0.4
7ce6760 
Update to v1.0.4
@ndegwamartin
Update Sync Filter Ignored conf - add more resources
54dff05
@ndegwamartin
Bump up version to v1.0.4
bd05b80
@ndegwamartin
Merge pull request #34 from onaio/addtional-sync-filter-configs
f97b6d4 
Update Sync Filter Ignored config - add more resources
@ndegwamartin ndegwamartin force-pushed the gateway-enhancements branch 2 times, most recently from 43f58bd to 23ce64a Compare November 21, 2024 18:01
dubdabasoduba and others added 23 commits November 27, 2024 15:15
@dubdabasoduba
- Adding the .env to the git ignore
2006510
@dubdabasoduba
⬆️ Upgrade versions in prep for release
90ed75b
@dubdabasoduba
⬆️ Upgrade the OpenSRP gateway dependency
3c6b336
@dubdabasoduba
Merge pull request #107 from onaio/feature/upgrade_main_version
13dd2c0 
Upgrade Version in prep for release
@ndegwamartin
Workaround Fetch Binary breaks with latest JPA HAPI FHIR Server
397e1ca
@ndegwamartin
Temp Fix build
6bf8cca
@ndegwamartin
Refactor Binary Fetch to use Native HAPI FHIR API
ac2149b
@ndegwamartin
Handle caching edgecase when SyncStrategyIds is empty
222c826 
- Throw illegal state exception on empty
- Return null instead of syncstrategy id to empty list map
@ndegwamartin
Alpha Test Release Version 2.2.3-alpha
e509610
@ndegwamartin
Release version 2.2.3
71ee657
@ndegwamartin
Add unit test ✅
d47baec
@ndegwamartin
Fixes broken REL sync for the assigned locations variant 🐛
df29901
@ndegwamartin
Merge pull request #84 from onaio/issue83-jpa-test
11173d1 
Workaround Fetch Binary breaks with latest JPA HAPI FHIR Server
@ndegwamartin
Fix REL sync strategy Caching bug 🐛
1e604bf 
- Refactor sync strategy fetch
@ndegwamartin
Refactor to support returning all paginated results
7067b7a 
- Fixes REL strategy not returning all records
@ndegwamartin
Refactor REL upstream fetch to single request
3861743
@ndegwamartin
Fix no _syncLocation specified exception
790fb71 
- Sort sync_locations when generating cache key
@ndegwamartin
Refactor chunked REL requests data fetch
50d3be9
@ndegwamartin
Update REL requests data fetch batch size to 100
44598fe
@lincmba @ndegwamartin
add more tests
ff8d5db
@lincmba @ndegwamartin
Test generateSyncStrategyIdsCacheKey
ecf8106
@ndegwamartin
Refactor getLocationHierarchyLocations to reuse Util helper
39a4cf5
@ndegwamartin
Release version 2.2.4
d0723a5
@ndegwamartin ndegwamartin changed the title FHIR Gateway Enhancements [DNM] FHIR Gateway Enhancements Dec 16, 2024
@ndegwamartin ndegwamartin marked this pull request as draft December 16, 2024 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dubdabasoduba dubdabasoduba dubdabasoduba requested changes

Assignees
No one assigned
Labels
Do Not Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@ndegwamartin @dubdabasoduba @rehammuzzamil @allan-on @LZRS @lincmba @pld @qiarie @bennsimon