Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Municipal Election support updates #434

Merged
merged 63 commits into from
Nov 6, 2024

Conversation

JohnMwashuma
Copy link
Member

@JohnMwashuma JohnMwashuma commented Oct 29, 2024

Fixes #435

Task checklist


  • Update reconciliation form to match the updated municipality election recon form.
    • Add number voter cards in the ballot box field on recon model
    • Remove number_signatures_in_vr on recon model
    • Add total of fields 5 and 7 to the recon model
    • Expose above fields on the recon form model
    • Add validation logic on the recon form to validate totals of fields 5 and 7
    • Update reconciliation tests
  • Add new quarantine triggers and remove old ones.
    • Registrants trigger
    • Voter cards trigger
    • Ballot papers trigger
    • Ballot inside the box trigger
    • Candidates votes trigger
    • Remove old triggers
    • Update Quality control tests
  • Update results json download logic to download results as expected by the results public site
    • Add the following fields:
      • candidate_id
      • gender
      • center_code
      • center_name
      • office_number
      • office_name
      • station_number
      • sub_con_code
      • sub_con_name
  • Updates markdown documentation to reflect changes.

@codecov-commenter
Copy link

codecov-commenter commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 94.28571% with 8 lines in your changes missing coverage. Please review.

Project coverage is 80.81%. Comparing base (1940021) to head (fdbcdb1).

Files with missing lines Patch % Lines
.../tally/views/reports/election_statistics_report.py 33.33% 4 Missing ⚠️
...pps/tally/views/data/sub_constituency_list_view.py 95.45% 2 Missing ⚠️
...ly_ho/apps/tally/views/data/candidate_list_view.py 0.00% 1 Missing ⚠️
tally_ho/libs/verify/quarantine_checks.py 96.96% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #434      +/-   ##
==========================================
+ Coverage   80.49%   80.81%   +0.32%     
==========================================
  Files         144      145       +1     
  Lines        9402     9439      +37     
==========================================
+ Hits         7568     7628      +60     
+ Misses       1834     1811      -23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JohnMwashuma JohnMwashuma changed the title [WIP] Municipal Election support updates Municipal Election support updates Nov 5, 2024
@JohnMwashuma JohnMwashuma requested a review from lincmba November 5, 2024 10:25
@JohnMwashuma JohnMwashuma merged commit 14af9ff into master Nov 6, 2024
8 checks passed
@JohnMwashuma JohnMwashuma deleted the update-exports-for-public-results-site branch November 6, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Municipal Election Support Updates
2 participants