Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hot fix duplicate results logic #437

Merged
merged 4 commits into from
Nov 8, 2024

Conversation

JohnMwashuma
Copy link
Member

@JohnMwashuma JohnMwashuma commented Nov 8, 2024

Task checklist


  • Refactor duplicate results tracking to work as expected
  • Filter duplicate results by tally id
  • Update duplicate result forms report title

@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 96.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.83%. Comparing base (753cc1e) to head (b2ef44c).

Files with missing lines Patch % Lines
tally_ho/apps/tally/views/super_admin.py 96.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #437      +/-   ##
==========================================
- Coverage   80.94%   80.83%   -0.12%     
==========================================
  Files         145      145              
  Lines        9436     9460      +24     
==========================================
+ Hits         7638     7647       +9     
- Misses       1798     1813      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JohnMwashuma JohnMwashuma force-pushed the hot-fix-duplicate-results-logic branch from 52e0a6e to b2ef44c Compare November 8, 2024 10:24
@JohnMwashuma JohnMwashuma merged commit 5259413 into master Nov 8, 2024
8 checks passed
@JohnMwashuma JohnMwashuma deleted the hot-fix-duplicate-results-logic branch November 8, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants