Target SDK 35 (includes lots of library updates)

[grote]

Since it upgrades all the things, we should do smoke tests on Android 5 to 15.

Closes #119, #107

[grote]

@lucasmz-dev could I interest you in testing this PR?

[lucasmz-dev]

Can you set up CI to post the build results lol I don't wanna build stuff locally for security reasons

[grote]

Added a commit for uploading the APK, let's see if this works.

[grote]

worked, APK available for download here: https://github.com/onionshare/onionshare-android/actions/runs/13163328184?pr=139

[lucasmz-dev]

Seems to look OK, the only thing I'm noticing is that, the plus icon at the bottom right is squared and not a circle.


[lucasmz-dev]

Minor but the about page seems to not use edge to edge (has black bars at the bottom)

[lucasmz-dev]

I'm a bit confused on where the pure black is meant to apply, if at all, right now, everything seems to use it, except when you have some file added and then pretty much everywhere inside there uses other colours

Pre-PR uses the pure black everywhere

[grote]

the only thing I'm noticing is that, the plus icon at the bottom right is squared and not a circle.

I think that's an automatic MD3 change: https://m3.material.io/components/floating-action-button/overview#fddf911f-14da-4d73-8601-59a6c2411c3c
However, we were cutting off too much off the edges, so I made them rounder again.

Minor but the about page seems to not use edge to edge (has black bars at the bottom)

should be fixed now

Pre-PR uses the pure black everywhere

ok, so there's some areas that are not pure black. the file list should be fixed. anything else that was pure black before?

[lucasmz-dev]

Looks alright to me, think that was pretty much it

[lucasmz-dev]

OK so I forgot to test how it looked in 3 button nav, and there a few things to fix there 🫠

1. The nav bar is a different color (might be a semi transparent layer I'm not sure)

[lucasmz-dev]

2. About page goes behind the nav bar at the end

[grote]

The nav bar is a different color (might be a semi transparent layer I'm not sure)

do you have some official source for how the navbar is supposed to look now?

I fixed the about page once again.

[lucasmz-dev]

do you have some official source for how the navbar is supposed to look now?

No, I'm going after what looks normal and how Google does it in their apps

[lucasmz-dev]

Huh. Drive has this issue as well but not Maps, I guess it's fine, then? It'd look better but well /shrug

[akwizgran]

Looks good! Tested on API 21 and 34. It's concerning how much churn there's been in the UI libraries - thanks for dealing with that.

[grote]

Thanks everyone for testing!