Public links to Github, docs and coffee #249
Closed
ManuelLeiner
started this conversation in
Ideas
Replies: 1 comment 1 reply
-
Hey! I think it's fair to have these links on an open-source package that's free to use and is constantly maintained. It does help motivate me when someone appreciates the work and sends me a coffee 😀 I think the solution to your situation is fairly easy - fork the repository. You can still have the latest features by pulling latest changes from this repo once in a while, and I think that's a small price to pay for you being able to remove the branding/links/coffee for your users. Let me know what you think! |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Hi there,
First of all, excellent package! I could have created an issue/bug report but let's be honest, the following is not actually something that is broken.
We might not be able to use this package due to the links to Github, the documentation and the coffee. I totally understand that you as the package owner deserve the recognition, but at the same time our customers will not be the target audience. The links won't even work when the log viewer is hosted on-premises in a closed network.
I am happy to provide a PR to conditionally display/hide:
Is there a realistic chance of such a PR being merged? I saw that the link in the bottom right corner is already configurable.
Keep up the great work and let me know if I can help. 🚀
Beta Was this translation helpful? Give feedback.
All reactions