Skip to content

[Bug] CI breaks due to the .length operator #1529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 8 tasks
lianhao opened this issue Feb 12, 2025 · 3 comments
Closed
1 of 8 tasks

[Bug] CI breaks due to the .length operator #1529

lianhao opened this issue Feb 12, 2025 · 3 comments
Assignees
Labels
bug Something isn't working CI

Comments

@lianhao
Copy link
Collaborator

lianhao commented Feb 12, 2025

Priority

P2-High

OS type

Ubuntu

Hardware type

Xeon-GNR

Installation method

  • Pull docker images from hub.docker.com
  • Build docker images from source
  • Other

Deploy method

  • Docker
  • Docker Compose
  • Kubernetes Helm Charts
  • Kubernetes GMC
  • Other

Running nodes

Single Node

What's the version?

GenAIExamples: 970b869
GenAIComps: b777db7

Description

PR opea-project/GenAIComps#1238 and #1470 added conditional CI step skip for both GenAIComps and GenAIExamples respectively. However, it seems that .length operator is not supported by github actions?

  1. In GenAIComps,image building on push event is always skipped, see this link for details.
  2. In GenAIExamples, helm chart e2e test is also skipped, see this link for details.

Reproduce steps

Manually retrigger the corresponding CI.

Raw log

Attachments

No response

@lianhao lianhao added bug Something isn't working CI labels Feb 12, 2025
@xiguiw
Copy link
Collaborator

xiguiw commented Feb 12, 2025

Hi @ZePan110,
Please help to look into this. Thanks!

@ZePan110
Copy link
Collaborator

I created two PRs to fix it. Pls review.
#1533
opea-project/GenAIComps#1282

@ZePan110
Copy link
Collaborator

The fix PR has been test passed and merged, so close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CI
Projects
None yet
Development

No branches or pull requests

3 participants