Skip to content

Open VideoQnA test #1476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 11 commits into from
Closed

Open VideoQnA test #1476

wants to merge 11 commits into from

Conversation

chensuyue
Copy link
Collaborator

@chensuyue chensuyue commented Jan 27, 2025 •
edited
Loading

Description

Open VideoQnA test closed by https://github.com/opea-project/GenAIExamples/pull/1293/files

Issues

List the issue or RFC link this PR is working on. If there is no such link, please mark it as n/a.

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

List the newly introduced 3rd party dependency if exists.

Tests

Describe the tests that you ran to verify your changes.

@chensuyue
open VideoQnA test
657ff42 
Signed-off-by: chensuyue <suyue.chen@intel.com>
@chensuyue chensuyue requested a review from XinyaoWa as a code owner January 27, 2025 06:54
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 27, 2025 •
edited
Loading

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Files

@joshuayao joshuayao self-requested a review January 27, 2025 06:56
chensuyue and others added 6 commits January 27, 2025 15:19
@chensuyue
remove entry point
86b4607 
Signed-off-by: chensuyue <suyue.chen@intel.com>
@lvliang-intel
fix dataprep and retrieval issue
017a33f 
Signed-off-by: lvliang-intel <liang1.lv@intel.com>
@lvliang-intel
update clip embedding
9092c06 
Signed-off-by: lvliang-intel <liang1.lv@intel.com>
@lvliang-intel
update yaml
44b4364 
Signed-off-by: lvliang-intel <liang1.lv@intel.com>
@lvliang-intel
Merge branch 'main' of https://github.com/opea-project/GenAIExamples …
4566a85 
…into suyue/test

Signed-off-by: lvliang-intel <liang1.lv@intel.com>
@lvliang-intel
fix typo
2fda870 
Signed-off-by: lvliang-intel <liang1.lv@intel.com>
This was referenced Feb 6, 2025
Closed
Closed
@chensuyue
Copy link
Collaborator Author

Depend on: opea-project/GenAIComps#1252

@Spycsh
Copy link
Member

Spycsh commented Feb 14, 2025

Fix numba cache issue in retriever_vdms following numba/numba#4032.

@Spycsh
Copy link
Member

Spycsh commented Feb 14, 2025 •
edited
Loading

@chensuyue @lvliang-intel I did debugging/fix the issues in commit on this VideoQnA UT and now I'm blocked by a bug: I am able to ingest the video by http_proxy= curl -XPOST xxxx:6007/v1/dataprep/ingest_videos -H "Content-Type: multipart/form-data" -F "files=@./data/op_1_0320241830.mp4", but I retrieve NOTHING using http_proxy= curl -X POST -d '{"text":"What is the main doing","embedding":'"${your_embedding}"'}' -H 'Content-Type: application/json' xxxx:7000/v1/retrieval. The similarity search seams return nothing.

Maybe @BaoHuiling @srinarayan-srikanthan @tileintel can help look at this issue? Thanks in advance and please let me know if you have any advices!

@xiguiw
Copy link
Collaborator

xiguiw commented Feb 25, 2025

@chensuyue @lvliang-intel I did debugging/fix the issues in commit on this VideoQnA UT and now I'm blocked by a bug: I am able to ingest the video by http_proxy= curl -XPOST xxxx:6007/v1/dataprep/ingest_videos -H "Content-Type: multipart/form-data" -F "files=@./data/op_1_0320241830.mp4", but I retrieve NOTHING using http_proxy= curl -X POST -d '{"text":"What is the main doing","embedding":'"${your_embedding}"'}' -H 'Content-Type: application/json' xxxx:7000/v1/retrieval. The similarity search seams return nothing.

Maybe @BaoHuiling @srinarayan-srikanthan @tileintel can help look at this issue? Thanks in advance and please let me know if you have any advices!

@BaoHuiling , @srinarayan-srikanthan @tileintel

Would you please check this?

@xiguiw
Copy link
Collaborator

xiguiw commented Mar 3, 2025 •
edited
Loading

talked to @BaoHuiling, she is busy with release these weeks. Cannot debug recently.
Asked sameh.gobriel@intel.com to help, sameh.gobriel forward this to Chaunte Lacewell (chaunte.w.lacewell@intel.com)

@yinghu5 yinghu5 requested review from tileintel and removed request for louie-tsai and srinarayan-srikanthan March 13, 2025 09:35
@yinghu5
Copy link
Collaborator

yinghu5 commented Mar 14, 2025

@XinyaoWa Hi Xinyao, Pelase help to check the PR, thank you a lot1

cwlacewe added a commit to cwlacewe/GenAIComps that referenced this pull request Mar 17, 2025
@cwlacewe
Update deprecated pydantic functions, fix dataprep vdms_multimodal ou…
c477648 
…tput, add vdms retriever without tei, make search engine and distance strategy configurable, fix vdms retrieval of clip, fix vdms dataprep test scripts, and fix vdms retrieval test script to test both with and without clip. These changes should help fix opea-project/GenAIExamples#1476

Signed-off-by: Lacewell, Chaunte W <chaunte.w.lacewell@intel.com>
@cwlacewe cwlacewe mentioned this pull request Mar 17, 2025
Merged
2 tasks
cwlacewe added a commit to cwlacewe/GenAIComps that referenced this pull request Mar 18, 2025
@cwlacewe
Update deprecated pydantic functions, fix dataprep vdms_multimodal ou…
e955604 
…tput, add vdms retriever without tei, make search engine and distance strategy configurable, fix vdms retrieval of clip, fix vdms dataprep test scripts, and fix vdms retrieval test script to test both with and without clip. These changes should help fix opea-project/GenAIExamples#1476

Signed-off-by: Lacewell, Chaunte W <chaunte.w.lacewell@intel.com>
cwlacewe added a commit to cwlacewe/GenAIComps that referenced this pull request Mar 19, 2025
@cwlacewe
Update deprecated pydantic functions, fix dataprep vdms_multimodal ou…
240a947 
…tput, add vdms retriever without tei, make search engine and distance strategy configurable, fix vdms retrieval of clip, fix vdms dataprep test scripts, and fix vdms retrieval test script to test both with and without clip. These changes should help fix opea-project/GenAIExamples#1476

Signed-off-by: Lacewell, Chaunte W <chaunte.w.lacewell@intel.com>
@cwlacewe cwlacewe mentioned this pull request Mar 19, 2025
Merged
1 task
@cwlacewe
Copy link
Contributor

Fix in #1696

@chensuyue
Copy link
Collaborator Author

Close this PR, use #1696 tracing this issue.

@chensuyue chensuyue closed this Mar 31, 2025
@chensuyue chensuyue deleted the suyue/test branch April 1, 2025 03:36
xiguiw pushed a commit that referenced this pull request Apr 12, 2025
@cwlacewe
Fix VideoQnA (#1696)
c476343 
This PR fixes the VideoQnA example.

Fixes Issues #1476 #1478 #1477

Signed-off-by: zhanmyz <yazhan.ma@intel.com>
Signed-off-by: Lacewell, Chaunte W <chaunte.w.lacewell@intel.com>
chyundunovDatamonsters pushed a commit to chyundunovDatamonsters/OPEA-GenAIExamples that referenced this pull request May 16, 2025
@cwlacewe @chyundunovDatamonsters
Fix VideoQnA (opea-project#1696)
cc23fb9 
This PR fixes the VideoQnA example.

Fixes Issues opea-project#1476 opea-project#1478 opea-project#1477

Signed-off-by: zhanmyz <yazhan.ma@intel.com>
Signed-off-by: Lacewell, Chaunte W <chaunte.w.lacewell@intel.com>
Signed-off-by: Chingis Yundunov <c.yundunov@datamonsters.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuayao joshuayao joshuayao approved these changes

@XinyaoWa XinyaoWa Awaiting requested review from XinyaoWa

@tileintel tileintel Awaiting requested review from tileintel

Assignees

@tileintel tileintel

Labels
A0 Scrube Dev Escalated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@chensuyue @Spycsh @xiguiw @yinghu5 @cwlacewe @joshuayao @tileintel @lvliang-intel