Enhance benchmark #1531
Merged
Enhance benchmark #1531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: letonghan <letong.han@intel.com>
letonghan
requested review from
lvliang-intel,
ftian1 and
chensuyue
as code owners
Dependency Review✅ No vulnerabilities or license issues found.Scanned Files |
for more information, see https://pre-commit.ci
lvliang-intel
approved these changes
Feb 13, 2025
…ples into enhance_benchmark
mkbhanda
reviewed
Feb 13, 2025
Thank for your comments! Other minor spelling issues will be fixed soon. |
Signed-off-by: letonghan <letong.han@intel.com>
Signed-off-by: letonghan <letong.han@intel.com>
Signed-off-by: letonghan <letong.han@intel.com>
Signed-off-by: letonghan <letong.han@intel.com>
for more information, see https://pre-commit.ci
letonghan
added a commit
to letonghan/GenAIEval
that referenced
this pull request
Feb 13, 2025
The poisson_load_shape.py file was located using relative path, refined to absolute path now so that outer files can call this function correctly. Found this issue in PR: opea-project/GenAIExamples#1531 Signed-off-by: letonghan <letong.han@intel.com>
1 task
|
The benchmark using |
|
This PR is not finished, please do not merge a PR with WIP flag. |
chensuyue
pushed a commit
to opea-project/GenAIEval
that referenced
this pull request
Feb 14, 2025
* Fix relative path issue for poisson. The poisson_load_shape.py file was located using relative path, refined to absolute path now so that outer files can call this function correctly. Found this issue in PR: opea-project/GenAIExamples#1531 Signed-off-by: letonghan <letong.han@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enhance the benchmark process:
benchmark.pyandbenchmark_chatqna.yamlbench_targetprocess partIssues
n/a
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
None
Tests
Local tested on k8s