From f441e17177ab153a7731d6b411f6eba39e4f52a3 Mon Sep 17 00:00:00 2001 From: chensuyue Date: Mon, 17 Mar 2025 10:24:57 +0800 Subject: [PATCH 1/2] fix input issue for manual-image-build.yml Signed-off-by: chensuyue --- .github/workflows/manual-example-workflow.yml | 4 ++-- .github/workflows/manual-image-build.yml | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/manual-example-workflow.yml b/.github/workflows/manual-example-workflow.yml index 9616f87032..7159b8a8a0 100644 --- a/.github/workflows/manual-example-workflow.yml +++ b/.github/workflows/manual-example-workflow.yml @@ -52,12 +52,12 @@ on: type: string inject_commit: default: false - description: "inject commit to docker images true or false" + description: "inject commit to docker images" required: false type: boolean use_model_cache: default: false - description: "use model cache true or false" + description: "use model cache" required: false type: boolean diff --git a/.github/workflows/manual-image-build.yml b/.github/workflows/manual-image-build.yml index b2b41ea0d7..92da9c2231 100644 --- a/.github/workflows/manual-image-build.yml +++ b/.github/workflows/manual-image-build.yml @@ -32,9 +32,9 @@ on: type: string inject_commit: default: false - description: "inject commit to docker images true or false" + description: "inject commit to docker images" required: false - type: string + type: boolean jobs: get-test-matrix: From f43025172b5a1e4b71600bf08ef1c7d0f42c2a85 Mon Sep 17 00:00:00 2001 From: chensuyue Date: Mon, 17 Mar 2025 11:47:26 +0800 Subject: [PATCH 2/2] fix condition Signed-off-by: chensuyue --- .github/workflows/_example-workflow.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/_example-workflow.yml b/.github/workflows/_example-workflow.yml index d56099a476..897f98e914 100644 --- a/.github/workflows/_example-workflow.yml +++ b/.github/workflows/_example-workflow.yml @@ -50,6 +50,9 @@ on: type: boolean jobs: +#################################################################################################### +# Image Build +#################################################################################################### pre-build-image-check: runs-on: ubuntu-latest outputs: @@ -64,9 +67,6 @@ jobs: echo "should_skip=false" >> $GITHUB_OUTPUT fi -#################################################################################################### -# Image Build -#################################################################################################### build-images: needs: [pre-build-image-check] if: ${{ needs.pre-build-image-check.outputs.should_skip == 'false' }} @@ -133,7 +133,7 @@ jobs: run: | set -x run_compose="false" - if [[ ${{ inputs.test_compose }} ]]; then + if [[ "${{ inputs.test_compose }}" == "true" ]]; then if [[ "${{ needs.pre-build-image-check.outputs.should_skip }}" == "false" && "${{ needs.build-images.result}}" == "success" || "${{ needs.pre-build-image-check.outputs.should_skip }}" == "true" ]]; then run_compose="true" fi