AgentQnA group log lines in test outputs for better readable logs. #1817
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 1 out of 6 changed files in this pull request and generated no comments.
Files not reviewed (5)
- AgentQnA/tests/step1_build_images.sh: Language not supported
- AgentQnA/tests/step1_build_images_rocm_vllm.sh: Language not supported
- AgentQnA/tests/test_compose_on_gaudi.sh: Language not supported
- AgentQnA/tests/test_compose_on_rocm.sh: Language not supported
- AgentQnA/tests/test_compose_vllm_on_rocm.sh: Language not supported
Comments suppressed due to low confidence (1)
AgentQnA/docker_image_build/build.yaml:24
- [nitpick] The service extension 'chatqna' may be unclear given the new service name 'vllm-gaudi'. Consider clarifying if this is intentional or if a more consistent naming would improve readability.
extends: chatqna
Dependency Review✅ No vulnerabilities or license issues found.Scanned FilesNone |
Signed-off-by: chensuyue <suyue.chen@intel.com>
Signed-off-by: chensuyue <suyue.chen@intel.com>
Signed-off-by: chensuyue <suyue.chen@intel.com>
Signed-off-by: chensuyue <suyue.chen@intel.com>
ZePan110
approved these changes
Apr 21, 2025
XuehaoSun
approved these changes
Apr 21, 2025
lvliang-intel
approved these changes
Apr 21, 2025
yongfengdu
pushed a commit
to yongfengdu/GenAIExamples
that referenced
this pull request
May 8, 2025
…pea-project#1817) Signed-off-by: chensuyue <suyue.chen@intel.com>
chyundunovDatamonsters
pushed a commit
to chyundunovDatamonsters/OPEA-GenAIExamples
that referenced
this pull request
May 16, 2025
…pea-project#1817) Signed-off-by: chensuyue <suyue.chen@intel.com> Signed-off-by: Chingis Yundunov <c.yundunov@datamonsters.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues
List the issue or RFC link this PR is working on. If there is no such link, please mark it as
n/a.Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
List the newly introduced 3rd party dependency if exists.
Tests
Describe the tests that you ran to verify your changes.