Skip to content

Update FinanceAgent v1.3 #1819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 16, 2025
Merged

Conversation

minmin-intel
Copy link
Collaborator

Description

  1. Update readme with more detailed instructions on how to use UI to set up endpoints and upload docs
  2. Update supervisor agent tools yaml to include research_agent as tool
  3. Update test scripts to have validations on supervisor outputs in single-turn and multi-turn tests
  4. Update readme with instructions on getting Finnhub and FinancialDatasets APIs and setting those env vars

Issues

List the issue or RFC link this PR is working on. If there is no such link, please mark it as n/a.

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

List the newly introduced 3rd party dependency if exists.

Tests

Describe the tests that you ran to verify your changes.

Signed-off-by: minmin-intel <minmin.hou@intel.com>
@Copilot Copilot AI review requested due to automatic review settings April 15, 2025 22:17
Copy link

github-actions bot commented Apr 15, 2025

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Files

None

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 9 out of 10 changed files in this pull request and generated 2 comments.

Files not reviewed (1)
  • FinanceAgent/tests/test_compose_on_gaudi.sh: Language not supported

minmin-intel and others added 4 commits April 15, 2025 22:18
Signed-off-by: minmin-intel <minmin.hou@intel.com>
Signed-off-by: minmin-intel <minmin.hou@intel.com>
Copy link
Collaborator

@lkk12014402 lkk12014402 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@rbrugaro rbrugaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@minmin-intel

  1. The diagram shows summarization as an agent, I suggest to change the color like the other tools and mention OPEA DocSum.
  2. Could we add the diagram we had to show the database and vector store design (what data goes where)?
  3. Should we provide more details in the README about the specific QA strategy that is implemented, also for the research agent?

@joshuayao joshuayao added this to OPEA Apr 16, 2025
@joshuayao joshuayao added this to the v1.3 milestone Apr 16, 2025
@minmin-intel
Copy link
Collaborator Author

@minmin-intel

  1. The diagram shows summarization as an agent, I suggest to change the color like the other tools and mention OPEA DocSum.
  2. Could we add the diagram we had to show the database and vector store design (what data goes where)?
  3. Should we provide more details in the README about the specific QA strategy that is implemented, also for the research agent?

@rbrugaro I added descriptions and diagrams for dataprep and finqa tool. I also updated the arch picture to show summarization is using docsum. I kept the color unchanged as I wanted to show that each light blue box is a microservice.

@rbrugaro
Copy link
Collaborator

@minmin-intel thank you! README looks great and the added explanations will make it a lot easier to follow the code.

@minmin-intel minmin-intel merged commit 8aa96c6 into opea-project:main Apr 16, 2025
15 checks passed
@github-project-automation github-project-automation bot moved this to Done in OPEA Apr 16, 2025
chyundunovDatamonsters pushed a commit to chyundunovDatamonsters/OPEA-GenAIExamples that referenced this pull request May 16, 2025
Signed-off-by: minmin-intel <minmin.hou@intel.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: Chingis Yundunov <c.yundunov@datamonsters.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants