-
Notifications
You must be signed in to change notification settings - Fork 282
Update FinanceAgent v1.3 #1819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update FinanceAgent v1.3 #1819
Conversation
Signed-off-by: minmin-intel <minmin.hou@intel.com>
Dependency Review✅ No vulnerabilities or license issues found.Scanned FilesNone |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 9 out of 10 changed files in this pull request and generated 2 comments.
Files not reviewed (1)
- FinanceAgent/tests/test_compose_on_gaudi.sh: Language not supported
Signed-off-by: minmin-intel <minmin.hou@intel.com>
…Examples into finagent-v1.3
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The diagram shows summarization as an agent, I suggest to change the color like the other tools and mention OPEA DocSum.
- Could we add the diagram we had to show the database and vector store design (what data goes where)?
- Should we provide more details in the README about the specific QA strategy that is implemented, also for the research agent?
@rbrugaro I added descriptions and diagrams for dataprep and finqa tool. I also updated the arch picture to show summarization is using docsum. I kept the color unchanged as I wanted to show that each light blue box is a microservice. |
Signed-off-by: minmin-intel <minmin.hou@intel.com>
@minmin-intel thank you! README looks great and the added explanations will make it a lot easier to follow the code. |
Signed-off-by: minmin-intel <minmin.hou@intel.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Chingis Yundunov <c.yundunov@datamonsters.com>
Description
Issues
List the issue or RFC link this PR is working on. If there is no such link, please mark it as
n/a
.Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
List the newly introduced 3rd party dependency if exists.
Tests
Describe the tests that you ran to verify your changes.