Skip to content

[CICD enhance] CodeTrans run CI with latest base image, group logs in GHA outputs. #1929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2025

Conversation

chensuyue
Copy link
Collaborator

@chensuyue chensuyue commented May 12, 2025

Description

  1. Enable latest base image test for CI.
  2. Group log lines in GHA outputs for better readable logs.

Issues

List the issue or RFC link this PR is working on. If there is no such link, please mark it as n/a.

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

List the newly introduced 3rd party dependency if exists.

Tests

Describe the tests that you ran to verify your changes.

@Copilot Copilot AI review requested due to automatic review settings May 12, 2025 02:51
@chensuyue chensuyue requested a review from Spycsh as a code owner May 12, 2025 02:51
Copy link

github-actions bot commented May 12, 2025

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Files

None

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the CodeTrans CI by enabling tests with the latest base image and improving log readability in the GHA outputs.

  • Adds build arguments (IMAGE_REPO and BASE_TAG) to pass registry and tag values.
  • Introduces an "extends" property to reuse configuration from the "codetrans" service.
Files not reviewed (7)
  • CodeTrans/Dockerfile: Language not supported
  • CodeTrans/tests/test_compose_on_gaudi.sh: Language not supported
  • CodeTrans/tests/test_compose_on_rocm.sh: Language not supported
  • CodeTrans/tests/test_compose_on_xeon.sh: Language not supported
  • CodeTrans/tests/test_compose_tgi_on_gaudi.sh: Language not supported
  • CodeTrans/tests/test_compose_tgi_on_xeon.sh: Language not supported
  • CodeTrans/tests/test_compose_vllm_on_rocm.sh: Language not supported
Comments suppressed due to low confidence (2)

CodeTrans/docker_image_build/build.yaml:8

  • Ensure that the new build argument 'IMAGE_REPO' is actively used in the Dockerfile so that the intended base image from ${REGISTRY} is correctly applied during the build.
IMAGE_REPO: ${REGISTRY}

CodeTrans/docker_image_build/build.yaml:50

  • Confirm that the 'extends' property is supported in this YAML configuration to correctly inherit properties from the 'codetrans' service and maintain expected behavior.
extends: codetrans

Signed-off-by: chensuyue <suyue.chen@intel.com>
@chensuyue chensuyue merged commit 26d0701 into main May 14, 2025
25 checks passed
@chensuyue chensuyue deleted the suyue/op2 branch May 14, 2025 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants