Skip to content

[CICD enhance] DocIndexRetriever run CI with latest base image, group logs in GHA outputs. #1932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2025

Conversation

chensuyue
Copy link
Collaborator

@chensuyue chensuyue commented May 12, 2025

Description

  1. Enable latest base image test for CI.
  2. Group log lines in GHA outputs for better readable logs.

Issues

List the issue or RFC link this PR is working on. If there is no such link, please mark it as n/a.

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

List the newly introduced 3rd party dependency if exists.

Tests

Describe the tests that you ran to verify your changes.

Signed-off-by: chensuyue <suyue.chen@intel.com>
@Copilot Copilot AI review requested due to automatic review settings May 12, 2025 03:27
Copy link

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Files

None

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the CI process for DocIndexRetriever by enabling tests with the latest base image and improving log grouping in GitHub Actions outputs.

  • Updated build arguments to use environment variables for IMAGE_REPO and BASE_TAG, enabling more flexible image builds.
  • Adjusted the Docker image build configuration to support the CI enhancement.
Files not reviewed (6)
  • DocIndexRetriever/Dockerfile: Language not supported
  • DocIndexRetriever/tests/test_compose_milvus_on_gaudi.sh: Language not supported
  • DocIndexRetriever/tests/test_compose_milvus_on_xeon.sh: Language not supported
  • DocIndexRetriever/tests/test_compose_on_gaudi.sh: Language not supported
  • DocIndexRetriever/tests/test_compose_on_xeon.sh: Language not supported
  • DocIndexRetriever/tests/test_compose_without_rerank_on_xeon.sh: Language not supported

@lvliang-intel lvliang-intel merged commit 7ee6f36 into main May 16, 2025
33 of 39 checks passed
@lvliang-intel lvliang-intel deleted the suyue/op5 branch May 16, 2025 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants