Skip to content

refactor: Combined the agent and manager binaries #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

Anu-Ra-g
Copy link

@Anu-Ra-g Anu-Ra-g commented Mar 7, 2025

Refactored the cluster proxy addon. Combined the agent and manager binaries and all the necessary changes.

This PR fixes: #867

@openshift-ci openshift-ci bot requested review from qiujian16 and xuezhaojun March 7, 2025 12:49
@xuezhaojun
Copy link
Member

Hi, @Anu-Ra-g Thanks for submiting the PR, could you split the go uprade and binary combination into 2 PRs?

Signed-off-by: Anu-Ra-g <nayakanurag078@gmail.com>
@Anu-Ra-g Anu-Ra-g reopened this Mar 7, 2025
Copy link

openshift-ci bot commented Mar 7, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Anu-Ra-g
Once this PR has been reviewed and has the lgtm label, please assign yue9944882 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
Copy link

openshift-ci bot commented Mar 7, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Anu-Ra-g
Once this PR has been reviewed and has the lgtm label, please assign yue9944882 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Anu-Ra-g
Copy link
Author

Anu-Ra-g commented Mar 7, 2025

@xuezhaojun I've divided this PR into two PRs. Please take a look.

Copy link

openshift-ci bot commented Mar 8, 2025

@Anu-Ra-g: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@xuezhaojun
Copy link
Member

/ok-to-test

@xuezhaojun
Copy link
Member

@Anu-Ra-g The PR failed in github checks, would you like to update it?

Also, could you add another main.go, for example, the /cmds/addon-all/main.go, we would like to keep the compitibility, make sure the old dockerfile and makefile commands can still work after the PR merged.

@Anu-Ra-g
Copy link
Author

Sorry @xuezhaojun I got busy while going through the ocm repo. I'll update this PR within today itself.

@Anu-Ra-g
Copy link
Author

@xuezhaojun Sorry I got a little busy. Can you please review and merge this PR and then I'll fix this one? I'm facing a little issue.

@xuezhaojun
Copy link
Member

@Anu-Ra-g No hurry at all, take your time and proceed at your own pace.

@Anu-Ra-g Anu-Ra-g closed this by deleting the head repository Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimize cluster-proxy image size
2 participants