-
Notifications
You must be signed in to change notification settings - Fork 25
refactor: Combined the agent and manager binaries #222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi, @Anu-Ra-g Thanks for submiting the PR, could you split the |
Signed-off-by: Anu-Ra-g <nayakanurag078@gmail.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Anu-Ra-g The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Anu-Ra-g The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@xuezhaojun I've divided this PR into two PRs. Please take a look. |
@Anu-Ra-g: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
@Anu-Ra-g The PR failed in github checks, would you like to update it? Also, could you add another main.go, for example, the |
Sorry @xuezhaojun I got busy while going through the ocm repo. I'll update this PR within today itself. |
@xuezhaojun Sorry I got a little busy. Can you please review and merge this PR and then I'll fix this one? I'm facing a little issue. |
@Anu-Ra-g No hurry at all, take your time and proceed at your own pace. |
Refactored the
cluster proxy
addon. Combined the agent and manager binaries and all the necessary changes.This PR fixes: #867