Upgrade golangci-lint to 1.64.8

- All above these version: github.com/golangci/golangci-lint/cmd/golangci-lint@v1.55.1 github.com/daixiang0/gci@v0.11.2 sigs.k8s.io/kustomize/kustomize/v5@v5.2.1 gosec => 2.22.2 kustomize => 5.6.
- Upgrade golang to 1.23
ref: https://issues.redhat.com/browse/ACM-8341
Signed-off-by: yiraeChristineKim <yikim@redhat.com>

Author: yiraeChristineKim

Diff for: api/v1/policy_webhook.go

@@ -100,7 +100,7 @@ func (r *Policy) validateName() error {
 
 	// 1 character for "."
 	if (utf8.RuneCountInString(r.Name) + utf8.RuneCountInString(r.Namespace)) > 62 {
-		log.Info(fmt.Sprintf("Invalid policy name/namespace: %s", errName.Error()))
+		log.Info("Invalid policy name/namespace: " + errName.Error())
 
 		return errName
 	}
@@ -126,7 +126,7 @@ func (r *Policy) validateRemediationAction() error {
 		if objUnstruct.GroupVersionKind().Kind == "ConfigurationPolicy" {
 			_, found, _ := unstructured.NestedString(objUnstruct.Object, "spec", "remediationAction")
 			if !found {
-				log.Info(fmt.Sprintf("Invalid remediationAction configuration: %s", errRemediation.Error()))
+				log.Info("Invalid remediationAction configuration: " + errRemediation.Error())
 
 				return errRemediation
 			}

Diff for: api/v1beta1/policyautomation_types.go

@@ -134,7 +134,7 @@ func init() {
 // ReplicatedComplianceHistory defines the replicated policy compliance details history.
 type ReplicatedComplianceHistory struct {
 	LastTimestamp metav1.Time `json:"lastTimestamp,omitempty" protobuf:"bytes,7,opt,name=lastTimestamp"`
-	Message       string      `json:"message,omitempty" protobuf:"bytes,4,opt,name=message"`
+	Message       string      `json:"message,omitempty"       protobuf:"bytes,4,opt,name=message"`
 }
 
 // ReplicatedDetailsPerTemplate defines the replicated policy compliance details and history.
@@ -153,10 +153,10 @@ type ReplicatedPolicyStatus struct {
 // ViolationContext defines the noncompliant replicated policy information that is sent to the
 // AnsibleJob through the extra_vars parameter.
 type ViolationContext struct {
-	TargetClusters   []string                          `json:"targetClusters" ansibleJob:"target_clusters"`
-	PolicyName       string                            `json:"policyName" ansibleJob:"policy_name"`
-	PolicyNamespace  string                            `json:"policyNamespace" ansibleJob:"policy_namespace"`
-	HubCluster       string                            `json:"hubCluster" ansibleJob:"hub_cluster"`
-	PolicySets       []string                          `json:"policySets" ansibleJob:"policy_sets"`
-	PolicyViolations map[string]ReplicatedPolicyStatus `json:"policyViolations" ansibleJob:"policy_violations"`
+	TargetClusters   []string                          `ansibleJob:"target_clusters"   json:"targetClusters"`
+	PolicyName       string                            `ansibleJob:"policy_name"       json:"policyName"`
+	PolicyNamespace  string                            `ansibleJob:"policy_namespace"  json:"policyNamespace"`
+	HubCluster       string                            `ansibleJob:"hub_cluster"       json:"hubCluster"`
+	PolicySets       []string                          `ansibleJob:"policy_sets"       json:"policySets"`
+	PolicyViolations map[string]ReplicatedPolicyStatus `ansibleJob:"policy_violations" json:"policyViolations"`
 }

Diff for: build/common/Makefile.common.mk

@@ -5,15 +5,15 @@
 # https://github.com/kubernetes-sigs/controller-tools/releases/latest
 CONTROLLER_GEN_VERSION := v0.16.3
 # https://github.com/kubernetes-sigs/kustomize/releases/latest
-KUSTOMIZE_VERSION := v5.4.3
+KUSTOMIZE_VERSION := v5.6.0
 # https://github.com/golangci/golangci-lint/releases/latest
-GOLANGCI_VERSION := v1.52.2
+GOLANGCI_VERSION := v1.64.8
 # https://github.com/mvdan/gofumpt/releases/latest
 GOFUMPT_VERSION := v0.7.0
 # https://github.com/daixiang0/gci/releases/latest
 GCI_VERSION := v0.13.5
 # https://github.com/securego/gosec/releases/latest
-GOSEC_VERSION := v2.21.3
+GOSEC_VERSION := v2.22.2
 # https://github.com/kubernetes-sigs/kubebuilder/releases/latest
 KBVERSION := 3.15.1
 # https://github.com/kubernetes/kubernetes/releases/latest

Diff for: build/common/config/.golangci.yml

@@ -24,6 +24,7 @@ run:
 linters:
   enable-all: true
   disable:
+    - mnd # Disabled as tech debt: Magic number detection
     - bodyclose
     - contextcheck # New linter to consider
     - cyclop

Diff for: controllers/automation/PolicyAutomationPredicate.go

@@ -34,7 +34,7 @@ var policyAuomtationPredicateFuncs = predicate.Funcs{
 
 		return policyAutomationNew.Spec.PolicyRef != ""
 	},
-	DeleteFunc: func(e event.DeleteEvent) bool {
+	DeleteFunc: func(_ event.DeleteEvent) bool {
 		return false
 	},
 }

Diff for: controllers/automation/ansible.go

@@ -122,16 +122,18 @@ func CreateAnsibleJob(policyAutomation *policyv1beta1.PolicyAutomation,
 	typesOf := values.Type()
 	// add every violationContext fields into mapExtraVars as well as the empty values,
 	// or when the whole violationContext is empty
-	for i := 0; i < values.NumField(); i++ {
+	for i := range values.NumField() {
 		tag := typesOf.Field(i).Tag
 		value := values.Field(i).Interface()
 
 		var fieldName string
-		if tag.Get("ansibleJob") != "" {
+
+		switch {
+		case tag.Get("ansibleJob") != "":
 			fieldName = tag.Get("ansibleJob")
-		} else if tag.Get("json") != "" {
+		case tag.Get("json") != "":
 			fieldName = strings.SplitN(tag.Get("json"), ",", 2)[0]
-		} else {
+		default:
 			fieldName = typesOf.Field(i).Name
 		}
 

Diff for: controllers/automation/policyPredicate.go

@@ -24,10 +24,10 @@ var policyPredicateFuncs = predicate.Funcs{
 
 		return !cmp.Equal(plcObjNew.Status.Status, plcObjOld.Status.Status)
 	},
-	CreateFunc: func(e event.CreateEvent) bool {
+	CreateFunc: func(_ event.CreateEvent) bool {
 		return false
 	},
-	DeleteFunc: func(e event.DeleteEvent) bool {
+	DeleteFunc: func(_ event.DeleteEvent) bool {
 		return false
 	},
 }