Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adopt annotions and remove gosec from codeql and move templates to .github repo #128

Merged
merged 16 commits into from
Feb 27, 2025
Merged

chore: adopt annotions and remove gosec from codeql and move templates to .github repo #128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
a35b10e
adopt exclusion annotions for gosec
morri-son Feb 21, 2025
99e514c
add permission to workflow
morri-son Feb 21, 2025
1351ef1
change annoations and remove gosec from codeql
morri-son Feb 24, 2025
3d65398
Merge remote-tracking branch 'origin/main' into adopt-exclusion-annot…
morri-son Feb 24, 2025
27db9aa
move templates to .github repo
morri-son Feb 24, 2025
da07b71
remove mend
morri-son Feb 24, 2025
c6e1e3b
correct typo
morri-son Feb 25, 2025
9683fac
remove cache
morri-son Feb 25, 2025
c885d66
schedule only
morri-son Feb 25, 2025
228bd12
bring back pr and push
morri-son Feb 25, 2025
c8ff694
correct nolint
morri-son Feb 25, 2025
be4558e
remove setup go
morri-son Feb 25, 2025
6b99b65
remove params
morri-son Feb 26, 2025
03bb82c
remove upload
morri-son Feb 27, 2025
b02d763
remove rapid param
morri-son Feb 27, 2025
5ef8dd7
Merge branch 'main' into adopt-exclusion-annotions-for-gosec
morri-son Feb 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 0 additions & 33 deletions .github/ISSUE_TEMPLATE/bug_report.md
View file
Open in desktop

This file was deleted.

8 changes: 0 additions & 8 deletions .github/ISSUE_TEMPLATE/custom.md
View file
Open in desktop

This file was deleted.

20 changes: 0 additions & 20 deletions .github/ISSUE_TEMPLATE/feature_request.md
View file
Open in desktop

This file was deleted.

7 changes: 0 additions & 7 deletions .github/PULL_REQUEST_TEMPLATE.md
View file
Open in desktop

This file was deleted.

1 change: 1 addition & 0 deletions .github/workflows/blackduck_scan.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,3 +52,4 @@ jobs:
blackducksca_token: ${{ secrets.BLACKDUCK_API_TOKEN }}
blackducksca_scan_full: false

Check warning

Code scanning / CodeQL

Unpinned tag for a non-immutable Action in workflow Medium

Unpinned 3rd party Action 'Blackduck SCA Scan' step
Uses Step
Loading
uses 'blackduck-inc/black-duck-security-scan' with ref 'v2.0.0', not a pinned commit hash
blackducksca_prComment_enabled: true

18 changes: 9 additions & 9 deletions .github/workflows/codeql.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,12 +93,12 @@ jobs:
with:
category: "/language:${{matrix.language}}"

gosec:
permissions:
# Required to upload SARIF files
security-events: write
# only required for workflows in private repositories
contents: read
# call reusable workflow from central '.github' repo
uses: open-component-model/.github/.github/workflows/code-scan.yml@main
secrets: inherit
# gosec:
# permissions:
# # Required to upload SARIF files
# security-events: write
# # only required for workflows in private repositories
# contents: read
# # call reusable workflow from central '.github' repo
# uses: open-component-model/.github/.github/workflows/code-scan.yml@main
# secrets: inherit
2 changes: 1 addition & 1 deletion .github/workflows/publish-image-main.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ on:
- '**/*.mod'
- '**/*.sum'
- 'config/**'
- 'Dockefile'
- 'Dockerfile'
jobs:
docker_publish:
runs-on: ubuntu-latest
Expand Down
2 changes: 1 addition & 1 deletion api/v1alpha1/constants.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ package v1alpha1
// Ocm credential config key for secrets.
const (
// OCMCredentialConfigKey defines the secret key to look for in case a user provides an ocm credential config.
OCMCredentialConfigKey = ".ocmcredentialconfig" // #nosec G101 -- it isn't a credential
OCMCredentialConfigKey = ".ocmcredentialconfig" //nolint:gosec // G101 -- it isn't a credential
// OCMConfigKey defines the secret or configmap key to look for in case a user provides an ocm config.
OCMConfigKey = ".ocmconfig"
// OCMLabelDowngradable defines the secret.
Expand Down
4 changes: 2 additions & 2 deletions test/utils/utils.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ func CheckOCMComponent(componentReference, ocmConfigPath string, options ...stri
}
c = append(c, componentReference)

cmd := exec.Command(c[0], c[1:]...) // #nosec G204 -- The argument list is constructed right above.
cmd := exec.Command(c[0], c[1:]...) //nolint:gosec // The argument list is constructed right above.
if _, err := utils.Run(cmd); err != nil {
return err
}
Expand All @@ -255,7 +255,7 @@ func GetOCMResourceImageRef(componentReference, resourceName, ocmConfigPath stri
}
c = append(c, "get", "resources", componentReference, resourceName, "-oJSON") // -oJSON is used to get the output in JSON format.

cmd := exec.Command(c[0], c[1:]...) // #nosec G204 -- The argument list is constructed right above.
cmd := exec.Command(c[0], c[1:]...) //nolint:gosec // The argument list is constructed right above.
output, err := utils.Run(cmd)
if err != nil {
return "", err
Expand Down
Loading