refactor: Move preventDefault in move up and move down events [FC-0076]

[ChrisChV]

Description

• Move the preventDefault function before the conditional in poll-move-up and poll-move-down click events.
• This change is to avoid opening a new tab page when clicking the Move up/Move down buttons when the Poll block is in an Iframe

Suporting information

• Related bug: Testing report of Advanced block editors
• Internal ticket: FAL-4041

Testing instructions

• Checkout this branch locally
• Add it to the tutor mount list using tutor mounts add ./xblock-poll
• Rebuild images using tutor images build openedx-dev
• Go to a Course
• Go to Settings > Advanced Settings on the header menu
• Make sure you have poll and survey on the "Advanced Module List"
• Ensure you have poll and survey on the LIBRARY_SUPPORTED_BLOCKS on the .env.development file of the frontend-app-authoring.
• Run tutor config save
• Edit a Unit for a Course
• Add a poll and survey blocks to a Unit.
• Copy both blocks and paste them into a library.
• Edit the poll block, check that the "Move up" and "Move down" buttons work well, and don't open a new page.
• Edit the survey block, check that the "Move up" and "Move down" buttons work well, and don't open a new page.

[pomegranited]

👍 Works perfectly :)

• I tested this by editing both poll and survey blocks in a library, a course (new UI), and in the legacy studio unit UI.
• I read through the code
• I checked for accessibility issues by using my keyboard to navigate
• Includes documentation N/A
• User-facing strings are extracted for translation N/A

[pomegranited]

@ChrisChV Oh I forgot -- you should bump the version in poll/__init__.py so we can tag a new release after merging this.