chore!: remove flag type property, add requirement level and footnotes #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
beeme1mr
changed the title
lukas-reining
approved these changes
Jan 28, 2025
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
beeme1mr
changed the title
beeme1mr
requested review from
kinyoklion,
thomaspoignant,
jonathannorris,
dyladan,
askpt,
aepfli,
chrfwow and
lukas-reining
chrfwow
approved these changes
Jan 31, 2025
aepfli
approved these changes
Feb 3, 2025
kinyoklion
approved these changes
Feb 3, 2025
toddbaert
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Notes
The proposal in OTel was rejected. I believe we should remove it from our spec for now. It can also be re-added later if necessary.
I have a draft PR in the JS SDK that adds a util method. It doesn't currently include the value type in the event payload.