Control field validation behaviour #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added story + test to document onBlur behaviour of TextField component.
... but only when all three parts of the date have been entered, as anything less is by definition invalid. This does imply that the field does not clear the error message whenever one of the inputs is cleared, as we can't tell the difference between correcting an input error vs someone entering an incomplete date.
robinmolen
approved these changes
Mar 11, 2025
| parameters: { | ||
| formik: { | ||
| initialValues: { | ||
| validateOnBlur: '', |
There was a problem hiding this comment.
Formik doesn't seem involved with the validating. So, should this parameter just be removed?
There was a problem hiding this comment.
okay - I understand the confusion!
- These are stories for the raw
TextFieldcomponent, which is rendered by the Formiotextfield,email... etc. - Any form field rendered with Formik requires at least a
nameparameter - The
nameprop is specified as arg on L89. For this test/story purpose, the name isvalidateOnBlur. Effectively resulting in<input type="text" name="validateOnBlur" /> - So, the formik context/parameters from the story expect some
initialValues, which is keyed by the field names. Hence,{validateOnBlur: ''}- the field has an empty string as value initially. - So, it doesn't have anything to do with the actual validation, it's just an illustrative form field name.
There was a problem hiding this comment.
Ah hahaha, okay yeah that makes sense 😅
robinmolen
requested changes
Mar 11, 2025
| return ( | ||
| <Formik | ||
| initialValues={initialValues} | ||
| initialErrors={initialErrors} | ||
| initialTouched={initialTouched} | ||
| enableReinitialize | ||
| onSubmit={async values => onSubmit(values)} | ||
| validateOnBlur={false} |
There was a problem hiding this comment.
Should this not be set by the context parameters?
There was a problem hiding this comment.
I've hardcoded them to reflect the actual implementation because enabling this validates the whole form rather than just the field that's touched.
robinmolen
approved these changes
Mar 11, 2025
sergei-maertens
deleted the
feature/69-control-field-validation-behaviour
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #69 (mostly)
This switches the validation behaviour to be per-field (until you submit the form as a whole), and triggers validation on blur of a field.
TODO: