Implement editgrid (repeating groups) - part 1 #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This an almost verbatim copy of the EditGrid components, with some re-organized SCSS and improved documentation.
It's a bit annoying that the icon library leaks down into everything, but for the time being we're not planning on supporting other icons. It would be possible to refactor this in the future to make it more pluggable, so the code to include an icon will be generalized a bit to make that clear. It's up to the downstream project to ensure the necessary stylesheets are loaded - we leave that out of scope because the complexities of font assets paths are a headache.
For the time being, we stick to font-awesome, but it should possible in the future to bring in your own SVG-based icons to render or alternative libraries, so the Icon component has been named in a generic way to make future expansion more natural. Plenty of challenges there that we will *not* tackle right now.
The editgrid state is now encapsulated in FieldArray, which provides the helpers to update/replace individual items at a particular index and/or remove them. It's up to the developer to still properly provide the array of items, using the same source of form state, but this allows automatic wrapping in EditGridItem components so that the implementation details don't have to leak to the outside too much. This actually unlocks a new feature where we can make per-item decisions about which controls for saving/removing are available, a thing we need for the appointment flow with products where you cannot remove the only product if there's only one. To enable adding items, only a blueprint/blank item needs to be provided as a prop (which can also change depending on the state, that's up to the outer component). Providing `null` for this blueprint disables the add button.
sergei-maertens
force-pushed
the
feature/36-editgrid
branch
from
4bd5d5d to
1757a89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #36 (partly)