Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove links to CKEditor and Quill #1

Merged
merged 2 commits into from
Mar 15, 2024
Merged

Remove links to CKEditor and Quill #1

merged 2 commits into from
Mar 15, 2024

Conversation

SilviaAmAm
Copy link
Collaborator

@SilviaAmAm SilviaAmAm marked this pull request as draft March 12, 2024 13:29
@SilviaAmAm SilviaAmAm force-pushed the fix/remove-links-to-vulnerable-libs branch from 6748f36 to d1fe8fd Compare March 12, 2024 13:30
@SilviaAmAm SilviaAmAm changed the base branch from 4.13.x to maykin-4.13.12 March 12, 2024 13:35
@SilviaAmAm SilviaAmAm force-pushed the fix/remove-links-to-vulnerable-libs branch 7 times, most recently from 63ea287 to 0451b00 Compare March 13, 2024 09:18
@SilviaAmAm SilviaAmAm marked this pull request as ready for review March 13, 2024 09:28
sergei-maertens
sergei-maertens approved these changes Mar 13, 2024
View reviewed changes
Copy link
Member

@sergei-maertens sergei-maertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So if I understand correctly, this removes WYSIWYG capabilities from Formio/the SDK entirely. That definitely makes the problem go away 😛

@SilviaAmAm SilviaAmAm force-pushed the fix/remove-links-to-vulnerable-libs branch from 0451b00 to ccb67ab Compare March 15, 2024 09:35
@SilviaAmAm
Copy link
Collaborator Author

So if I understand correctly, this removes WYSIWYG capabilities from Formio/the SDK entirely. That definitely makes the problem go away 😛

Yes, this is what I went for!

@SilviaAmAm SilviaAmAm merged commit 9d99e60 into maykin-4.13.12 Mar 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergei-maertens sergei-maertens sergei-maertens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SilviaAmAm @sergei-maertens