Skip to content

Commit

Permalink
👷 [#445] Enable type checking in CI
Browse files Browse the repository at this point in the history
Added some missing type definitions, but not everything is there
yet.
  • Loading branch information
sergei-maertens committed Mar 3, 2025
1 parent 31289a4 commit 00d05e7
Show file tree
Hide file tree
Showing 4 changed files with 27 additions and 2 deletions.
10 changes: 8 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,17 @@ jobs:
echo "version=${VERSION}" >> $GITHUB_OUTPUT
- name: Build Javascript
- name: Install dependencies
run: |
echo "Building version $VITE_VERSION"
npm ci
npm run build:design-tokens
- name: Run type checker
run: npm run buid:typecheck

- name: Build Javascript
run: |
echo "Building version $VITE_VERSION"
VITE_VERSION=${VITE_VERSION} npm run build
env:
VITE_VERSION: ${{ steps.build-args.outputs.version }}
Expand Down
16 changes: 16 additions & 0 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@
"scripts": {
"start": "npm run build:design-tokens && vite",
"build": "npm run build:umd && npm run build:esm && npm run build:esm-bundle",
"build:typecheck": "tsc --noEmit",
"build:umd": "BUILD_TARGET=umd vite build",
"build:esm": "BUILD_TARGET=esm vite build",
"build:esm-bundle": "BUILD_TARGET=esm-bundle vite build",
Expand Down Expand Up @@ -121,6 +122,7 @@
"@testing-library/react": "^16.2.0",
"@testing-library/user-event": "^14.6.0",
"@trivago/prettier-plugin-sort-imports": "^4.3.0",
"@types/leaflet": "^1.9.16",
"@typescript-eslint/parser": "^8.19.0",
"@utrecht/component-library-css": "1.0.0-alpha.604",
"@utrecht/component-library-react": "1.0.0-alpha.353",
Expand Down
1 change: 1 addition & 0 deletions tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
"strictNullChecks": true,
"allowSyntheticDefaultImports": true,
"noErrorTruncation": true,
"allowJs": true,
"paths": {
"@/*": ["./*"],
"@/sb-decorators": ["../.storybook/decorators.tsx"]
Expand Down

0 comments on commit 00d05e7

Please sign in to comment.