-
Notifications
You must be signed in to change notification settings - Fork 6
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
🎨 [#445] Ensure map interaction tests are not flaky
* Added a test id for testing-library to the map container so that the interaction tests only start running when the container is visible * Added robustness for interaction elements that may exist in the DOM but not be visible yet because map tiles are still loading waitFor has longer default timeouts than canvas.findBy* queries, and while the latter can be specified, the element is find before it's visible and there are still race conditions. For this reason, the visibility check is decoupled from the lookup expectation.
- Loading branch information
1 parent
c6b1f69
commit 2cf3ec0
Showing
2 changed files
with
26 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters