👌 [open-formulieren/open-forms#3680] PR Feedback

Author: SilviaAmAm

src/components/LoginOptions/LoginOptions.stories.js

@@ -89,6 +89,17 @@ export const Display = {
         },
         url: '#',
       },
+      {
+        identifier: 'eHerkenning',
+        label: 'eHerkenning',
+        logo: {
+          appearance: 'light',
+          href: 'https://www.eherkenning.nl/',
+          title: 'eHerkenning',
+          imageSrc: './eherkenning.png',
+        },
+        url: '#',
+      },
     ],
   },
 };

src/components/LoginOptions/LoginOptionsDisplay.js

@@ -36,7 +36,7 @@ const LoginOptionsDisplay = ({
         </>
       )}
 
-      {cosignLoginOptions && cosignLoginOptions.length > 0 && (
+      {cosignLoginOptions?.length > 0 && (
         <div className={getBEMClassName('login-options__cosign')}>
           <h2 className={getBEMClassName('login-options__caption')}>
             <FormattedMessage

src/components/LoginOptions/index.js

@@ -12,9 +12,9 @@ import LoginOptionsDisplay from './LoginOptionsDisplay';
 const LoginOptions = ({form, onFormStart}) => {
   const config = useContext(ConfigContext);
 
-  let loginAsYourselfOptions = [];
-  let loginAsGemachtigdeOptions = [];
-  let cosignLoginOptions = [];
+  const loginAsYourselfOptions = [];
+  const loginAsGemachtigdeOptions = [];
+  const cosignLoginOptions = [];
 
   form.loginOptions.forEach(option => {
     let readyOption = {...option};

src/types/FormattedLoginOption.js

@@ -8,6 +8,7 @@ const FormattedLoginOption = PropTypes.shape({
     title: PropTypes.string.isRequired,
     imageSrc: PropTypes.string.isRequired,
     href: PropTypes.string,
+    appearance: PropTypes.bool,
   }),
   isForGemachtigde: PropTypes.bool,
 });