[open-formulieren/open-forms#3805] Fix label if field is not required

Backport-of: #638
open-formulieren · Jan 26, 2024 · b510818 · b510818
1 parent 43baf7c
commit b510818
Show file tree

Hide file tree

Showing 6 changed files with 86 additions and 9 deletions.
diff --git a/src/components/forms/Label.js b/src/components/forms/Label.js
@@ -17,14 +17,18 @@ export const LabelContent = ({id, disabled = false, isRequired = false, type, ch
         [`utrecht-form-label--${type}`]: type,
       })}
     >
-      <FormattedMessage
-        description="Form field label, field possibly optional"
-        defaultMessage="{withAsterisk, select, true {<label></label>} other {<label></label> (optional)}}"
-        values={{
-          withAsterisk: requiredFieldsWithAsterisk,
-          label: () => children,
-        }}
-      />
+      {isRequired ? (
+        <>{children}</>
+      ) : (
+        <FormattedMessage
+          description="Form field label, field not required"
+          defaultMessage="{withAsterisk, select, true {<label></label>} other {<label></label> (not required)}}"
+          values={{
+            withAsterisk: requiredFieldsWithAsterisk,
+            label: () => children,
+          }}
+        />
+      )}
     </FormLabel>
   );
 };

diff --git a/src/components/modals/FormStepSaveModal.js b/src/components/modals/FormStepSaveModal.js
@@ -138,7 +138,6 @@ const FormStepSaveModal = ({
                 values={{numberOfDays: suspendFormUrlLifetime}}
               />
             </Body>
-
             <EmailField
               name="email"
               isRequired

diff --git a/src/i18n/compiled/en.json b/src/i18n/compiled/en.json
@@ -785,6 +785,38 @@
       "value": "m"
     }
   ],
+  "OnfuIr": [
+    {
+      "options": {
+        "other": {
+          "value": [
+            {
+              "children": [
+              ],
+              "type": 8,
+              "value": "label"
+            },
+            {
+              "type": 0,
+              "value": " (not required)"
+            }
+          ]
+        },
+        "true": {
+          "value": [
+            {
+              "children": [
+              ],
+              "type": 8,
+              "value": "label"
+            }
+          ]
+        }
+      },
+      "type": 5,
+      "value": "withAsterisk"
+    }
+  ],
   "P194bo": [
     {
       "type": 0,

diff --git a/src/i18n/compiled/nl.json b/src/i18n/compiled/nl.json
@@ -785,6 +785,38 @@
       "value": "m"
     }
   ],
+  "OnfuIr": [
+    {
+      "options": {
+        "other": {
+          "value": [
+            {
+              "children": [
+              ],
+              "type": 8,
+              "value": "label"
+            },
+            {
+              "type": 0,
+              "value": " (not required)"
+            }
+          ]
+        },
+        "true": {
+          "value": [
+            {
+              "children": [
+              ],
+              "type": 8,
+              "value": "label"
+            }
+          ]
+        }
+      },
+      "type": 5,
+      "value": "withAsterisk"
+    }
+  ],
   "P194bo": [
     {
       "type": 0,

diff --git a/src/i18n/messages/en.json b/src/i18n/messages/en.json
@@ -364,6 +364,11 @@
     "description": "Placeholder for month part of a date",
     "originalDefault": "m"
   },
+  "OnfuIr": {
+    "defaultMessage": "{withAsterisk, select, true {<label></label>} other {<label></label> (not required)}}",
+    "description": "Form field label, field not required",
+    "originalDefault": "{withAsterisk, select, true {<label></label>} other {<label></label> (not required)}}"
+  },
   "P194bo": {
     "defaultMessage": "Invalid input: must start with \"{startsWith}\".",
     "description": "ZOD 'invalid_string' error message, with startsWith",

diff --git a/src/i18n/messages/nl.json b/src/i18n/messages/nl.json
@@ -368,6 +368,11 @@
     "isTranslated": true,
     "originalDefault": "m"
   },
+  "OnfuIr": {
+    "defaultMessage": "{withAsterisk, select, true {<label></label>} other {<label></label> (not required)}}",
+    "description": "Form field label, field not required",
+    "originalDefault": "{withAsterisk, select, true {<label></label>} other {<label></label> (niet verplicht)}}"
+  },
   "P194bo": {
     "defaultMessage": "De ingevoerde waarde moet beginnen met \"{startsWith}\".",
     "description": "ZOD 'invalid_string' error message, with startsWith",