Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OF#3680] Handle multiple cosign auth methods for cosign #639

Merged
merged 4 commits into from
Feb 2, 2024

Conversation

SilviaAmAm
Copy link
Contributor

Copy link

codecov bot commented Jan 26, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (831dd12) 74.85% compared to head (7945fd8) 74.29%.
Report is 3 commits behind head on main.

Files Patch % Lines
src/components/LoginOptions/LoginOptionsDisplay.js 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #639      +/-   ##
==========================================
- Coverage   74.85%   74.29%   -0.57%     
==========================================
  Files         224      225       +1     
  Lines        4542     4548       +6     
  Branches     1211     1211              
==========================================
- Hits         3400     3379      -21     
- Misses       1103     1130      +27     
  Partials       39       39              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SilviaAmAm SilviaAmAm force-pushed the feature/3680-remove-auth-plugin-from-cosign branch from 6509247 to 9605fb9 Compare January 26, 2024 16:10
@vaszig vaszig self-assigned this Jan 31, 2024
Copy link
Contributor

@vaszig vaszig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this but I have some small remarks-questions.

@SilviaAmAm SilviaAmAm force-pushed the feature/3680-remove-auth-plugin-from-cosign branch from 9605fb9 to a5819f8 Compare January 31, 2024 09:35
@sergei-maertens sergei-maertens merged commit ab73f2b into main Feb 2, 2024
14 of 15 checks passed
@sergei-maertens sergei-maertens deleted the feature/3680-remove-auth-plugin-from-cosign branch February 2, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cosign V2 component configuration should not require authPlugin to be specified
3 participants