-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OF#4917] Update buttons styling (buttons position) #787
base: main
Are you sure you want to change the base?
Conversation
Bundle ReportChanges will decrease total bundle size by 879 bytes (-0.01%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: @open-formulieren/sdk-esmAssets Changed:
Files in
Files in
view changes for bundle: @open-formulieren/sdk-OpenForms-umdAssets Changed:
Files in
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #787 +/- ##
==========================================
+ Coverage 83.99% 84.27% +0.28%
==========================================
Files 246 245 -1
Lines 4817 4809 -8
Branches 1275 1278 +3
==========================================
+ Hits 4046 4053 +7
+ Misses 742 726 -16
- Partials 29 30 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
9f211a5
to
db08f20
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we even still need this whole toolbar thing? IMO we can refactor that whole thing away now, it's a left-over from the prototype anyway and I've been meaning to get rid of it for ages.
As I was updating the buttons I saw that this is not needed but I thought I should keep it in case we need to do something different with the buttons in the near future. I am telling this as I understood that these changes have to be approved from the municipalities in any case. |
Let's use this opportunity to remove this toolbar thing :) |
db08f20
to
a9256f8
Compare
a9256f8
to
6adc89f
Compare
6adc89f
to
49a77b8
Compare
Closes open-formulieren/open-forms#4917
Requires open-formulieren/design-tokens#51
The following screenshots show the new position of the buttons (mobile version already handles the correct order):