Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OF#4917] Update buttons styling (buttons position) #787

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vaszig
Copy link
Contributor

@vaszig vaszig commented Jan 27, 2025

Closes open-formulieren/open-forms#4917

Requires open-formulieren/design-tokens#51

The following screenshots show the new position of the buttons (mobile version already handles the correct order):

  • Start page

startpage

  • Form step

formstep

  • Summary

summary

@vaszig vaszig changed the title [OF#4917] Update buttons styling [OF#4917] Update buttons styling (buttons position) Jan 27, 2025
Copy link

codecov bot commented Jan 27, 2025

Bundle Report

Changes will decrease total bundle size by 879 bytes (-0.01%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
@open-formulieren/sdk-OpenForms-umd 4.78MB -432 bytes (-0.01%) ⬇️
@open-formulieren/sdk-esm 4.75MB -447 bytes (-0.01%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: @open-formulieren/sdk-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/sdk-*.js -431 bytes 1.01MB -0.04%
assets/index-*.js -16 bytes 25.25kB -0.06%

Files in assets/sdk-*.js:

  • ./src/components/Summary/GenericSummary.jsx → Total Size: 3.13kB

  • ./src/components/PostCompletionViews/PostCompletionView.jsx → Total Size: 1.84kB

  • ./src/components/modals/FormStepSaveModal.jsx → Total Size: 7.99kB

  • ./src/components/ButtonsGroup/index.jsx → Total Size: 2.35kB

  • ./src/components/FormStep/index.jsx → Total Size: 17.53kB

  • ./src/components/EmailVerification/EmailVerificationForm.jsx → Total Size: 5.85kB

  • ./src/components/Sessions/SessionTrackerModal.jsx → Total Size: 4.27kB

  • ./src/components/ExistingSubmissionOptions.jsx → Total Size: 1.11kB

  • ./src/components/SummaryConfirmation/index.jsx → Total Size: 2.09kB

  • ./src/components/AbortButton/AbortButton.jsx → Total Size: 1.88kB

  • ./src/styles.scss → Total Size: 0 bytes

Files in assets/index-*.js:

  • ./src/components/appointments/SubmitRow.jsx → Total Size: 1.11kB

  • ./src/components/appointments/cancel/CancelAppointment.jsx → Total Size: 5.41kB

view changes for bundle: @open-formulieren/sdk-OpenForms-umd

Assets Changed:

Asset Name Size Change Total Size Change (%)
open-*.js -432 bytes 3.49MB -0.01%

Files in open-*.js:

  • ./src/components/Summary/GenericSummary.jsx → Total Size: 3.13kB

  • ./src/styles.scss → Total Size: 0 bytes

  • ./src/components/appointments/cancel/CancelAppointment.jsx → Total Size: 5.41kB

  • ./src/components/appointments/SubmitRow.jsx → Total Size: 1.11kB

  • ./src/components/modals/FormStepSaveModal.jsx → Total Size: 8.0kB

  • ./src/components/SummaryConfirmation/index.jsx → Total Size: 2.09kB

  • ./src/components/FormStep/index.jsx → Total Size: 17.88kB

  • ./src/components/Sessions/SessionTrackerModal.jsx → Total Size: 4.27kB

  • ./src/components/EmailVerification/EmailVerificationForm.jsx → Total Size: 5.85kB

  • ./src/components/ExistingSubmissionOptions.jsx → Total Size: 1.11kB

  • ./src/components/ButtonsGroup/index.jsx → Total Size: 2.35kB

  • ./src/components/PostCompletionViews/PostCompletionView.jsx → Total Size: 1.84kB

  • ./src/components/AbortButton/AbortButton.jsx → Total Size: 1.88kB

Copy link

codecov bot commented Jan 27, 2025

Codecov Report

Attention: Patch coverage is 82.75862% with 5 lines in your changes missing coverage. Please review.

Project coverage is 84.27%. Comparing base (adf8ff7) to head (a9256f8).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/components/Sessions/SessionTrackerModal.jsx 0.00% 3 Missing ⚠️
src/components/SummaryConfirmation/index.jsx 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #787      +/-   ##
==========================================
+ Coverage   83.99%   84.27%   +0.28%     
==========================================
  Files         246      245       -1     
  Lines        4817     4809       -8     
  Branches     1275     1278       +3     
==========================================
+ Hits         4046     4053       +7     
+ Misses        742      726      -16     
- Partials       29       30       +1     
Flag Coverage Δ
storybook 77.94% <82.75%> (+0.34%) ⬆️
vitest 62.56% <60.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sergei-maertens sergei-maertens marked this pull request as draft January 28, 2025 15:56
@vaszig vaszig force-pushed the of-4917/update-buttons-style branch from 9f211a5 to db08f20 Compare February 21, 2025 07:33
@vaszig
Copy link
Contributor Author

vaszig commented Feb 21, 2025

Formstep

image

Summary

image

Mobile

image

@vaszig vaszig marked this pull request as ready for review February 21, 2025 08:17
Copy link
Member

@sergei-maertens sergei-maertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we even still need this whole toolbar thing? IMO we can refactor that whole thing away now, it's a left-over from the prototype anyway and I've been meaning to get rid of it for ages.

@vaszig
Copy link
Contributor Author

vaszig commented Feb 27, 2025

Do we even still need this whole toolbar thing? IMO we can refactor that whole thing away now, it's a left-over from the prototype anyway and I've been meaning to get rid of it for ages.

As I was updating the buttons I saw that this is not needed but I thought I should keep it in case we need to do something different with the buttons in the near future. I am telling this as I understood that these changes have to be approved from the municipalities in any case.

@sergei-maertens
Copy link
Member

Do we even still need this whole toolbar thing? IMO we can refactor that whole thing away now, it's a left-over from the prototype anyway and I've been meaning to get rid of it for ages.

As I was updating the buttons I saw that this is not needed but I thought I should keep it in case we need to do something different with the buttons in the near future. I am telling this as I understood that these changes have to be approved from the municipalities in any case.

Let's use this opportunity to remove this toolbar thing :)

@sergei-maertens sergei-maertens marked this pull request as draft March 3, 2025 10:45
@vaszig vaszig force-pushed the of-4917/update-buttons-style branch from db08f20 to a9256f8 Compare March 3, 2025 15:29
@vaszig vaszig marked this pull request as ready for review March 3, 2025 15:30
@vaszig vaszig requested a review from sergei-maertens March 3, 2025 15:30
@vaszig vaszig marked this pull request as draft March 4, 2025 09:02
@vaszig vaszig removed the request for review from sergei-maertens March 6, 2025 09:52
@vaszig vaszig force-pushed the of-4917/update-buttons-style branch from a9256f8 to 6adc89f Compare March 7, 2025 09:54
@vaszig vaszig force-pushed the of-4917/update-buttons-style branch from 6adc89f to 49a77b8 Compare March 7, 2025 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consistente links uitgelijnde buttons en flexibele stylingopties voor formulieren
2 participants