Define the assets directory for a build using SDK_VERSION #796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle ReportChanges will decrease total bundle size by 14 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: @open-formulieren/sdk-OpenForms-umdAssets Changed:
view changes for bundle: @open-formulieren/sdk-esmAssets Changed:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #796 +/- ##
==========================================
- Coverage 84.29% 83.86% -0.44%
==========================================
Files 245 245
Lines 4808 4808
Branches 1279 1272 -7
==========================================
- Hits 4053 4032 -21
- Misses 726 747 +21
Partials 29 29
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
robinmolen
force-pushed
the
fix/vite-build-dir-based-on-build-version
branch
from
9809656 to
adcd669
Compare
robinmolen
changed the title
For release builds we want to the assets to be placed in `/dist/[release number]`. This logic was present in the previous build setup, with CRA. In the re-structure of the SDK project, #724, the build process of CRA was replaced with vite. But this logic rule was lost in the process
robinmolen
force-pushed
the
fix/vite-build-dir-based-on-build-version
branch
from
adcd669 to
e4b3a57
Compare
robinmolen
changed the title
sergei-maertens
approved these changes
Feb 20, 2025
|
Good catch! |
robinmolen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For release builds we want to the assets to be placed in
/dist/[release number].This logic was present in the previous build setup, with CRA. In the re-structure of the SDK project, #724, the build process of CRA was replaced with vite. But this logic rule was lost in the process.
If the env variable
SDK_VERSIONis present, and it isn't 'latest', the assets directory will be/dist/[SDK_VERSION]. If theSDK_VERSIONisn't available, or it set to 'latest', the build assets will be placed in the regular/dist.