-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update outdated dependencies #802
Conversation
This should give a more accurate theme preview for The Hague in our own storybook.
…rdam/design-tokens package
* Removed obsoleted remarks * Updated sample code to use TS syntax * Added section about typescript usage
This only affects the theme preview in our storybook.
These were inadvertedly specified in the dependencies.
Vite uses it under the hood for postcss, but we don't use it directly anymore as esbuild uses a different targets definition, so the current dependency + config were misleading.
The utrecht component library may depend on an older version still, but that should then be properly captured in a local node_modules folder. All usages were checked that they still exist and are not affected by the breaking changes.
Bundle ReportChanges will increase total bundle size by 226.32kB (2.37%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: @open-formulieren/sdk-esmAssets Changed:
Files in
Files in
view changes for bundle: @open-formulieren/sdk-OpenForms-umdAssets Changed:
Files in
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #802 +/- ##
==========================================
+ Coverage 83.28% 83.42% +0.13%
==========================================
Files 233 233
Lines 4631 4633 +2
Branches 1178 1180 +2
==========================================
+ Hits 3857 3865 +8
+ Misses 744 738 -6
Partials 30 30
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This valueIsNumericString is a terrible prop name - passing it as true means that the string itself can be interpreted directly as a number, but we have the opposite in Dutch locale if the '.' character is the thousand separator.
It should be faster :)
f15ec1e
to
1d1a4aa
Compare
This was probably added out of confusion about which package does what, but we only use @utrecht/components in our SCSS pipeline.
Partially closes #445
Let's see what breaks in our CI pipeline...
Expand to see left over outdated packages