Upgrade to @utrecht/components v7 #803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #803 +/- ##
==========================================
+ Coverage 83.29% 83.42% +0.12%
==========================================
Files 233 233
Lines 4633 4633
Branches 1193 1180 -13
==========================================
+ Hits 3859 3865 +6
+ Misses 744 738 -6
Partials 30 30
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Bundle ReportChanges will increase total bundle size by 40 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: @open-formulieren/sdk-esmAssets Changed:
view changes for bundle: @open-formulieren/sdk-OpenForms-umdAssets Changed:
Files in
|
sergei-maertens
changed the title
This is the latest version before the scss mixins are removed. We can run a first visual regression check on this state.
* Converted the decorators to typescript * De-duplicated the utrecht document decorator * Ensured that it's only wired up in the preview.js of Storybook - the intent was clearly to enable it globally, but the duplicate was still added in other places. That is now cleaned up. This should resolve the visual regressions related to spacing of the utrecht-button-group, which only happened in storybook because the --utrecht-space-around was set for some unclear reason. This is now removed, and the expected behaviour for edit grid is now working.
sergei-maertens
force-pushed
the
chore/445-upgrade-utrecht-components
branch
from
aeca7ae to
3bfe705
Compare
Doing a click + ArrowDown on a react select seems to have a race condition where sometimes the *next* option gets 'focus', resulting in it being higlighted with a different color, which in turn trips the Chromatic snapshots as it's toggling between which option is focused. Replacing this with an explicit focus + ArrowDown causes the menu to open and seems to avoid the race condition. The click used to be required in older versions of testing library and react-select to properly focus the input/select when the browser window itself doesn't have focus, e.g. when live-reloading saved code in SB which would lead to a frustrating DX.
sergei-maertens
force-pushed
the
chore/445-upgrade-utrecht-components
branch
from
4c2fb8c to
715eda1
Compare
Adapted the few places where we directly import the mixin for certain components, which has been moved into the package src and is no longer in the dist/css directory. Other imports have been updated to refer to the package itself, as that resolves to the CSS file inside, and we can now use the @use rule in a bunch of places rather than sticking with the deprecated @import.
Contains fix for the breaking alert component changes.
sergei-maertens
force-pushed
the
chore/445-upgrade-utrecht-components
branch
from
14e26f8 to
207d9a4
Compare
sergei-maertens
changed the title
The real test to see if we have broken CSS 😬
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires open-formulieren/design-tokens#52
We've been on the latest 1.0.0 alpha version for too long, while 7.4.0 is available and this package is no longer being published (in favour of individual component packages). To get there we: