🗃️ [#4486] Clean up zgw_apis migrations until v2.6.7

sergei-maertens · sergei-maertens · commit 8db60ef98f41 · 2024-07-04T17:21:12.000+02:00
Not squashed yet since it causes test failures in tests that are
relevant for 2.7
diff --git a/src/openforms/registrations/contrib/zgw_apis/migrations/0007_move_singleton_data.py b/src/openforms/registrations/contrib/zgw_apis/migrations/0007_move_singleton_data.py
@@ -3,63 +3,12 @@
 from django.db import migrations
 
 
-def move_singleton_data_to_zgw_api_set_model(apps, _):
-    ZgwConfig = apps.get_model("zgw_apis", "ZgwConfig")
-    ZGWApiGroupConfig = apps.get_model("zgw_apis", "ZGWApiGroupConfig")
-
-    solo_model = ZgwConfig.objects.first()
-    if not solo_model:
-        return
-
-    new_config_set = ZGWApiGroupConfig(
-        name="ZGW API",
-        zrc_service=solo_model.zrc_service,
-        drc_service=solo_model.drc_service,
-        ztc_service=solo_model.ztc_service,
-        zaaktype=solo_model.zaaktype,
-        informatieobjecttype=solo_model.informatieobjecttype,
-        organisatie_rsin=solo_model.organisatie_rsin,
-        zaak_vertrouwelijkheidaanduiding=solo_model.zaak_vertrouwelijkheidaanduiding,
-        doc_vertrouwelijkheidaanduiding=solo_model.doc_vertrouwelijkheidaanduiding,
-        auteur=solo_model.auteur,
-    )
-    new_config_set.save()
-
-
-def reconfigure_zgw_solo_model(apps, _):
-    ZgwConfig = apps.get_model("zgw_apis", "ZgwConfig")
-    ZGWApiGroupConfig = apps.get_model("zgw_apis", "ZGWApiGroupConfig")
-
-    solo_model = ZgwConfig.objects.first()
-    zgw_api_group = ZGWApiGroupConfig.objects.all().order_by("pk").first()
-
-    if not solo_model or not zgw_api_group:
-        return
-
-    solo_model.zrc_service = zgw_api_group.zrc_service
-    solo_model.drc_service = zgw_api_group.drc_service
-    solo_model.ztc_service = zgw_api_group.ztc_service
-    solo_model.zaaktype = zgw_api_group.zaaktype
-    solo_model.informatieobjecttype = zgw_api_group.informatieobjecttype
-    solo_model.organisatie_rsin = zgw_api_group.organisatie_rsin
-    solo_model.zaak_vertrouwelijkheidaanduiding = (
-        zgw_api_group.zaak_vertrouwelijkheidaanduiding
-    )
-    solo_model.doc_vertrouwelijkheidaanduiding = (
-        zgw_api_group.doc_vertrouwelijkheidaanduiding
-    )
-    solo_model.auteur = zgw_api_group.auteur
-    solo_model.save()
-
-
 class Migration(migrations.Migration):
 
     dependencies = [
         ("zgw_apis", "0006_zgwapigroupconfig"),
     ]
 
-    operations = [
-        migrations.RunPython(
-            move_singleton_data_to_zgw_api_set_model, reconfigure_zgw_solo_model
-        ),
-    ]
+    # RunPython operation removed as part of 2.7 release cycle, which requires 2.6.7 to
+    # be run first.
+    operations = []
diff --git a/src/openforms/registrations/contrib/zgw_apis/migrations/0009_add_default.py b/src/openforms/registrations/contrib/zgw_apis/migrations/0009_add_default.py
@@ -3,27 +3,12 @@
 from django.db import migrations
 
 
-def attach_default_zgw_group(apps, _):
-    ZgwConfig = apps.get_model("zgw_apis", "ZgwConfig")
-    ZGWApiGroupConfig = apps.get_model("zgw_apis", "ZGWApiGroupConfig")
-
-    # There should be at most one (since it was created by migration 0007_move_singleton_data). But in case that there
-    # are multiple, we just pick one.
-    zgw_api_group = ZGWApiGroupConfig.objects.first()
-    if not zgw_api_group:
-        return
-
-    solo_config = ZgwConfig.objects.get()
-    solo_config.default_zgw_api_group = zgw_api_group
-    solo_config.save()
-
-
 class Migration(migrations.Migration):
 
     dependencies = [
         ("zgw_apis", "0008_auto_20230608_1443"),
     ]
 
-    operations = [
-        migrations.RunPython(attach_default_zgw_group, migrations.RunPython.noop),
-    ]
+    # RunPython operation removed as part of 2.7 release cycle, which requires 2.6.7 to
+    # be run first.
+    operations = []
diff --git a/src/openforms/registrations/contrib/zgw_apis/tests/test_migrations.py b/src/openforms/registrations/contrib/zgw_apis/tests/test_migrations.py
@@ -1,210 +1,10 @@
 from django.db.migrations.state import StateApps
 
-from zgw_consumers.api_models.constants import VertrouwelijkheidsAanduidingen
 from zgw_consumers.constants import APITypes
 
 from openforms.utils.tests.test_migrations import TestMigrations
 
 
-class MoveExistingZGWConfigMigrationTests(TestMigrations):
-    migrate_from = "0006_zgwapigroupconfig"
-    migrate_to = "0007_move_singleton_data"
-    app = "zgw_apis"
-
-    def setUpBeforeMigration(self, apps):
-        ZgwConfig = apps.get_model("zgw_apis", "ZgwConfig")
-        Service = apps.get_model("zgw_consumers", "Service")
-
-        zrc = Service.objects.create(
-            label="Zaak API",
-            api_root="http://www.example-zrc.com/api/v1/",
-            api_type=APITypes.zrc,
-        )
-        drc = Service.objects.create(
-            label="Document API",
-            api_root="http://www.example-drc.com/api/v1/",
-            api_type=APITypes.drc,
-        )
-        ztc = Service.objects.create(
-            label="Catalogi API",
-            api_root="http://www.example-ztc.com/api/v1/",
-            api_type=APITypes.ztc,
-        )
-
-        ZgwConfig.objects.create(
-            zrc_service=zrc,
-            drc_service=drc,
-            ztc_service=ztc,
-            zaaktype="http://www.example-ztc.com/api/v1/zaaktype/111-222-333",
-            informatieobjecttype="http://www.example-ztc.com/api/v1/zaaktype/111-222-333",
-            organisatie_rsin="100000009",
-            zaak_vertrouwelijkheidaanduiding=VertrouwelijkheidsAanduidingen.openbaar,
-            doc_vertrouwelijkheidaanduiding=VertrouwelijkheidsAanduidingen.beperkt_openbaar,
-            auteur="testeerrr",
-        )
-
-    def test_services_migrated_correctly(self):
-        ZGWApiGroupConfig = self.apps.get_model("zgw_apis", "ZGWApiGroupConfig")
-
-        migrated_services = ZGWApiGroupConfig.objects.all()
-
-        self.assertEqual(1, migrated_services.count())
-
-        group = migrated_services.get()
-
-        self.assertEqual(group.zrc_service.label, "Zaak API")
-        self.assertEqual(group.drc_service.label, "Document API")
-        self.assertEqual(group.ztc_service.label, "Catalogi API")
-        self.assertEqual(
-            group.zaaktype, "http://www.example-ztc.com/api/v1/zaaktype/111-222-333"
-        )
-        self.assertEqual(
-            group.informatieobjecttype,
-            "http://www.example-ztc.com/api/v1/zaaktype/111-222-333",
-        )
-        self.assertEqual(group.organisatie_rsin, "100000009")
-        self.assertEqual(
-            group.zaak_vertrouwelijkheidaanduiding,
-            VertrouwelijkheidsAanduidingen.openbaar,
-        )
-        self.assertEqual(
-            group.doc_vertrouwelijkheidaanduiding,
-            VertrouwelijkheidsAanduidingen.beperkt_openbaar,
-        )
-        self.assertEqual(group.auteur, "testeerrr")
-
-
-class ReconfigureSoloModelBackwardsMigrationTests(TestMigrations):
-    migrate_to = "0006_zgwapigroupconfig"
-    migrate_from = "0007_move_singleton_data"
-    app = "zgw_apis"
-
-    def setUpBeforeMigration(self, apps):
-        ZGWApiGroupConfig = apps.get_model("zgw_apis", "ZGWApiGroupConfig")
-        ZgwConfig = apps.get_model("zgw_apis", "ZgwConfig")
-
-        ZgwConfig.objects.create()
-        self.zgw_group1 = ZGWApiGroupConfig.objects.create(
-            name="ZGW API 1",
-            auteur="test 1",
-        )
-        self.zgw_group2 = ZGWApiGroupConfig.objects.create(
-            name="ZGW API 2",
-            auteur="test 2",
-        )
-        self.assertTrue(self.zgw_group1.pk < self.zgw_group2.pk)
-
-    def test_solo_reconfigured_correctly(self):
-        ZgwConfig = self.apps.get_model("zgw_apis", "ZgwConfig")
-
-        solo = ZgwConfig.objects.get()
-
-        self.assertEqual(solo.auteur, "test 1")
-
-
-class BackwardsMigrationNoZGWGroupTests(TestMigrations):
-    migrate_to = "0006_zgwapigroupconfig"
-    migrate_from = "0007_move_singleton_data"
-    app = "zgw_apis"
-
-    def setUpBeforeMigration(self, apps):
-        ZgwConfig = apps.get_model("zgw_apis", "ZgwConfig")
-
-        ZgwConfig.objects.create()
-
-    def test_solo_reconfigured_correctly(self):
-        ZgwConfig = self.apps.get_model("zgw_apis", "ZgwConfig")
-
-        solo = ZgwConfig.objects.get()
-
-        self.assertIsNone(solo.zrc_service)
-
-
-class NoZgwConfigDoesntCreateZGWApiGroupMigrationTest(TestMigrations):
-    migrate_from = "0006_zgwapigroupconfig"
-    migrate_to = "0007_move_singleton_data"
-    app = "zgw_apis"
-
-    def setUpBeforeMigration(self, apps):
-        ZgwConfig = apps.get_model("zgw_apis", "ZgwConfig")
-
-        self.assertFalse(ZgwConfig.objects.exists())
-
-    def test_no_zgw_api_group_created(self):
-        ZGWApiGroupConfig = self.apps.get_model("zgw_apis", "ZGWApiGroupConfig")
-
-        self.assertFalse(ZGWApiGroupConfig.objects.exists())
-
-
-class AddDefaultToSoloModelTests(TestMigrations):
-    migrate_from = "0008_auto_20230608_1443"
-    migrate_to = "0009_add_default"
-    app = "zgw_apis"
-
-    def setUpBeforeMigration(self, apps):
-        ZGWApiGroupConfig = apps.get_model("zgw_apis", "ZGWApiGroupConfig")
-        ZgwConfig = apps.get_model("zgw_apis", "ZgwConfig")
-        Service = apps.get_model("zgw_consumers", "Service")
-
-        zrc = Service.objects.create(
-            label="Zaak API",
-            api_root="http://www.example-zrc.com/api/v1/",
-            api_type=APITypes.zrc,
-        )
-        drc = Service.objects.create(
-            label="Document API",
-            api_root="http://www.example-drc.com/api/v1/",
-            api_type=APITypes.drc,
-        )
-        ztc = Service.objects.create(
-            label="Catalogi API",
-            api_root="http://www.example-ztc.com/api/v1/",
-            api_type=APITypes.ztc,
-        )
-
-        ZgwConfig.objects.create()
-        self.zgw_group = ZGWApiGroupConfig.objects.create(
-            name="ZGW API",
-            zrc_service=zrc,
-            drc_service=drc,
-            ztc_service=ztc,
-            zaaktype="http://www.example-ztc.com/api/v1/zaaktype/111-222-333",
-            informatieobjecttype="http://www.example-ztc.com/api/v1/zaaktype/111-222-333",
-            organisatie_rsin="100000009",
-            zaak_vertrouwelijkheidaanduiding=VertrouwelijkheidsAanduidingen.openbaar,
-            doc_vertrouwelijkheidaanduiding=VertrouwelijkheidsAanduidingen.beperkt_openbaar,
-            auteur="testeerrr",
-        )
-
-    def test_services_migrated_correctly(self):
-        ZgwConfig = self.apps.get_model("zgw_apis", "ZgwConfig")
-
-        solo = ZgwConfig.objects.get()
-
-        self.assertEqual(solo.default_zgw_api_group.pk, self.zgw_group.pk)
-
-
-class NoZgwGroupLeavesConfigEmptyMigrationTest(TestMigrations):
-    migrate_from = "0008_auto_20230608_1443"
-    migrate_to = "0009_add_default"
-    app = "zgw_apis"
-
-    def setUpBeforeMigration(self, apps):
-        ZGWApiGroupConfig = apps.get_model("zgw_apis", "ZGWApiGroupConfig")
-        ZgwConfig = apps.get_model("zgw_apis", "ZgwConfig")
-
-        self.assertFalse(ZGWApiGroupConfig.objects.exists())
-
-        ZgwConfig.objects.create()
-
-    def test_no_zgw_api_group_created(self):
-        ZgwConfig = self.apps.get_model("zgw_apis", "ZgwConfig")
-
-        solo = ZgwConfig.objects.get()
-
-        self.assertIsNone(solo.default_zgw_api_group)
-
-
 class MoveDefaultsToFormTest(TestMigrations):
     app = "zgw_apis"
     migrate_from = "0010_zgwapigroupconfig_content_json"
