Skip to content

Commit a6c00a4

Browse files
committed
✅ [#3755] Test migrations
1 parent fb6d850 commit a6c00a4

File tree

2 files changed

+46
-0
lines changed

2 files changed

+46
-0
lines changed

src/openforms/formio/tests/test_migration_converters.py

+14
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
from ..migration_converters import (
44
ensure_licensplate_validate_pattern,
55
ensure_postcode_validate_pattern,
6+
prevent_datetime_components_from_emptying_invalid_values,
67
)
78
from ..typing import Component
89

@@ -35,3 +36,16 @@ def test_noop(self):
3536
changed = ensure_postcode_validate_pattern(component)
3637

3738
self.assertFalse(changed)
39+
40+
41+
class DatetimeTests(SimpleTestCase):
42+
def test_update(self):
43+
component: Component = {
44+
"type": "datetime",
45+
"key": "datetime",
46+
}
47+
48+
changed = prevent_datetime_components_from_emptying_invalid_values(component)
49+
50+
self.assertTrue(changed)
51+
self.assertTrue(component["customOptions"]["allowInvalidPreload"])

src/openforms/forms/tests/test_migrations.py

+32
Original file line numberDiff line numberDiff line change
@@ -911,3 +911,35 @@ def test_postcode_validate_added(self):
911911
postcode["validate"]["pattern"],
912912
r"^[1-9][0-9]{3} ?(?!sa|sd|ss|SA|SD|SS)[a-zA-Z]{2}$",
913913
)
914+
915+
916+
class DatetimeAllowInvalidInputTests(TestMigrations):
917+
app = "forms"
918+
migrate_from = "0103_fix_component_problems"
919+
migrate_to = "0104_allow_invalid_input_datetime"
920+
921+
def setUpBeforeMigration(self, apps):
922+
FormDefinition = apps.get_model("forms", "FormDefinition")
923+
924+
self.form_definition = FormDefinition.objects.create(
925+
name="Datetime",
926+
slug="datetime",
927+
configuration={
928+
"components": [
929+
{"key": "datetime", "type": "datetime"},
930+
{"key": "time", "type": "time"},
931+
]
932+
},
933+
)
934+
935+
def test_datetime_component_modified(self):
936+
self.form_definition.refresh_from_db()
937+
938+
self.assertTrue(
939+
self.form_definition.configuration["components"][0]["customOptions"][
940+
"allowInvalidPreload"
941+
]
942+
)
943+
self.assertNotIn(
944+
"customOptions", self.form_definition.configuration["components"][1]
945+
)

0 commit comments

Comments
 (0)