✅ Improve test robustness

sergei-maertens · sergei-maertens · commit ca65f8a57c7c · 2024-07-04T15:42:44.000+02:00
Optional file uploads with validation errors remain blank and don't
block form validation/submission, so while there were issues with the
upload, the test didn't fail.

Now the test fails if the upload didn't succeed.
diff --git a/src/openforms/tests/e2e/test_file_upload.py b/src/openforms/tests/e2e/test_file_upload.py
@@ -37,6 +37,9 @@ def setUpTestData():
                             "key": "fileUpload",
                             "label": "File Upload",
                             "storage": "url",
+                            "validate": {
+                                "required": True,
+                            },
                         }
                     ]
                 },

Original file line number	Diff line number	Diff line change
`@@ -37,6 +37,9 @@ def setUpTestData():`
`37`	`37`	`"key": "fileUpload",`
`38`	`38`	`"label": "File Upload",`
`39`	`39`	`"storage": "url",`
	`40`	`+ "validate": {`
	`41`	`+ "required": True,`
	`42`	`+ },`
`40`	`43`	`}`
`41`	`44`	`]`
`42`	`45`	`},`