[#3688] Phase 1 - Add Objecttypes API endpoints #3860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Viicos
commented
Feb 9, 2024
src/openforms/registrations/contrib/objects_api/tests/test_api_endpoints.py
Outdated
Show resolved
Hide resolved
33 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/3688-phase1-end #3860 +/- ##
===========================================================
- Coverage 96.34% 96.33% -0.01%
===========================================================
Files 708 711 +3
Lines 22187 22233 +46
Branches 2545 2548 +3
===========================================================
+ Hits 21375 21418 +43
- Misses 565 568 +3
Partials 247 247 ☔ View full report in Codecov by Sentry. |
src/openforms/registrations/contrib/objects_api/tests/test_api_endpoints.py
Outdated
Show resolved
Hide resolved
Viicos
force-pushed
the
feature/3688-objecttypes-api-endpoints
branch
from
7511fc9 to
0787384
Compare
Viicos
force-pushed
the
feature/3688-objecttypes-api-endpoints
branch
from
0d8adaf to
30d7062
Compare
| def setUp(self) -> None: | ||
| super().setUp() | ||
|
|
||
| self.endpoint = reverse_lazy("api:objects_api:object-types") |
There was a problem hiding this comment.
FYI - you can just use reverse_lazy with a class attribute for these kind of situations
sergei-maertens
approved these changes
Feb 13, 2024
sergei-maertens
merged commit 8bf5568
into
feature/3688-phase1-end
24 of 25 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #3688
To be resolved: