Read only submission report content

[robinmolen]

Closes open-formulieren/security-issues#34

Changes

The submission report content is now read-only in the admin

Checklist

Check off the items that are completed or not relevant.

• Impact on features

  • Checked copying a form
  • Checked import/export of a form
  • Config checks in the configuration overview admin page
  • Problem detection in the admin email digest is handled

• Release management

  • I have labelled the PR as "needs-backport" accordingly

• I have updated the translations assets (you do NOT need to provide translations)

  • Ran ./bin/makemessages_js.sh
  • Ran ./bin/compilemessages_js.sh

• Dockerfile/scripts

  • Updated the Dockerfile with the necessary scripts from the ./bin folder

• Commit hygiene

  • Commit messages refer to the relevant Github issue
  • Commit messages explain the "why" of change, not the how

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.73%. Comparing base (e7e8155) to head (e53e274).
Report is 21 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #5100   +/-   ##
=======================================
  Coverage   96.73%   96.73%           
=======================================
  Files         775      775           
  Lines       26662    26666    +4     
  Branches     3468     3469    +1     
=======================================
+ Hits        25792    25796    +4     
  Misses        608      608           
  Partials      262      262           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sergei-maertens]

Additionally I'd configure the PrivateMediaMixin so that the files are not downloaded with inline directives in the Content-Disposition header. I think you should be able to get there with:

• https://django-privates.readthedocs.io/en/latest/reference.html#privates.admin.PrivateMediaMixin.get_private_media_view_options to pass django-sendfile2 options to the underlying view. Should be achievable with the private_media_view_options attribute on the admin class.
• passing attachment=True to https://django-sendfile2.readthedocs.io/en/latest/django_sendfile.utils.html#django_sendfile.utils.sendfile

The sendfile options are consumed here: https://github.com/sergei-maertens/django-privates/blob/27c7391ef82479f5d99fb6542647ab999b3ebd2a/privates/views.py#L38

[robinmolen]

Regarding the Content-Disposition header in the SDK (the download link citizens will receive after submitting a form):

I assume the test findings were from a pre-2.8.0 environment. In the release of 2.8.0 the download link shown in the SDK was changed. From that point the correct Content-Disposition header were used (change was made in ticket #4488).

[sergei-maertens]

I'll take a look at django-privates now for the readonly field :)