Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/3.1.0 alpha.0 re-record vcr cassettes #5111

Merged
merged 11 commits into from
Feb 18, 2025

Conversation

robinmolen
Copy link
Contributor

Partly closes #5102

Changes

Re-record VCR tests

If I understand the template/checklist correctly, Suwinet cannot be tested at this moment.

Suwinet: openforms.prefill.contrib.suwinet (testenv access has been retracted and won't
be reinstated)

These tests indeed don't run correctly, resulting a statuscode 500. As such, the VCR recordings for Suwinet haven't been updated

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Problem detection in the admin email digest is handled
  • Release management

    • I have labelled the PR as "needs-backport" accordingly
  • I have updated the translations assets (you do NOT need to provide translations)

    • Ran ./bin/makemessages_js.sh
    • Ran ./bin/compilemessages_js.sh
  • Dockerfile/scripts

    • Updated the Dockerfile with the necessary scripts from the ./bin folder
  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how

@robinmolen robinmolen requested a review from vaszig February 17, 2025 16:49
@robinmolen robinmolen linked an issue Feb 17, 2025 that may be closed by this pull request
39 tasks
@robinmolen robinmolen marked this pull request as ready for review February 17, 2025 16:51
Copy link

codecov bot commented Feb 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.74%. Comparing base (dd88286) to head (8d1d66b).
Report is 12 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5111      +/-   ##
==========================================
- Coverage   96.75%   96.74%   -0.02%     
==========================================
  Files         774      774              
  Lines       26657    26657              
  Branches     3468     3468              
==========================================
- Hits        25791    25788       -3     
- Misses        605      608       +3     
  Partials      261      261              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vaszig
Copy link
Contributor

vaszig commented Feb 18, 2025

And yes, you are correct the Suwinet VCR tests cannot be part of this, it's broken.

@robinmolen robinmolen force-pushed the release/3.1.0-alpha.0-re-record-vcr-cassettes branch from 8e4115b to 8d1d66b Compare February 18, 2025 10:06
@robinmolen robinmolen merged commit 4328272 into master Feb 18, 2025
17 of 18 checks passed
@robinmolen robinmolen deleted the release/3.1.0-alpha.0-re-record-vcr-cassettes branch February 18, 2025 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prepare release 3.1.0-alpha.0
2 participants