-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release/3.1.0 alpha.0 re-record vcr cassettes #5111
Merged
robinmolen
merged 11 commits into
master
from
release/3.1.0-alpha.0-re-record-vcr-cassettes
Feb 18, 2025
Merged
Release/3.1.0 alpha.0 re-record vcr cassettes #5111
robinmolen
merged 11 commits into
master
from
release/3.1.0-alpha.0-re-record-vcr-cassettes
Feb 18, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
39 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5111 +/- ##
==========================================
- Coverage 96.75% 96.74% -0.02%
==========================================
Files 774 774
Lines 26657 26657
Branches 3468 3468
==========================================
- Hits 25791 25788 -3
- Misses 605 608 +3
Partials 261 261 ☔ View full report in Codecov by Sentry. |
vaszig
approved these changes
Feb 18, 2025
src/openforms/registrations/contrib/zgw_apis/tests/test_api_endpoints.py
Outdated
Show resolved
Hide resolved
And yes, you are correct the Suwinet VCR tests cannot be part of this, it's broken. |
8e4115b
to
8d1d66b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partly closes #5102
Changes
Re-record VCR tests
If I understand the template/checklist correctly, Suwinet cannot be tested at this moment.
These tests indeed don't run correctly, resulting a statuscode 500. As such, the VCR recordings for Suwinet haven't been updated
Checklist
Check off the items that are completed or not relevant.
Impact on features
Release management
I have updated the translations assets (you do NOT need to provide translations)
./bin/makemessages_js.sh
./bin/compilemessages_js.sh
Dockerfile/scripts
./bin
folderCommit hygiene