svg sanitizing #5120
Merged
svg sanitizing #5120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5120 +/- ##
=======================================
Coverage 96.75% 96.75%
=======================================
Files 777 778 +1
Lines 26724 26741 +17
Branches 3474 3474
=======================================
+ Hits 25856 25873 +17
Misses 606 606
Partials 262 262 ☔ View full report in Codecov by Sentry. |
viktorvanwijk
requested changes
Feb 26, 2025
robinmolen
force-pushed
the
issue/svg-sanitize
branch
from
e923789 to
16355a9
Compare
Added svg sanitation to the SVGOrImageField class, using the bleach library. The sanitation eliminates script tags, event handlers and non-essential tags and attributes (like Animation stuff, data-*, href) The allowed tags and attributes are derived from the MDN documentation about SVG content.
robinmolen
force-pushed
the
issue/svg-sanitize
branch
2 times, most recently
from
e97e373 to
87d6438
Compare
robinmolen
force-pushed
the
issue/svg-sanitize
branch
from
87d6438 to
cd1f6a6
Compare
sergei-maertens
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes open-formulieren/security-issues#35
Changes
Added svg sanitizing to
SVGOrImageFieldChecklist
Check off the items that are completed or not relevant.
Impact on features
Release management
I have updated the translations assets (you do NOT need to provide translations)
./bin/makemessages_js.sh./bin/compilemessages_js.shDockerfile/scripts
./binfolderCommit hygiene