Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch release 3.0.5 #5128

Merged
merged 4 commits into from
Mar 3, 2025
Merged

Patch release 3.0.5 #5128

merged 4 commits into from
Mar 3, 2025

Conversation

robinmolen
Copy link
Contributor

@robinmolen robinmolen commented Feb 27, 2025

Partly closes #5126

Changes

Patch release for 3.0.5. Updated backend translations and changelog, and bumped version

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Problem detection in the admin email digest is handled
  • Release management

    • I have labelled the PR as "needs-backport" accordingly
  • I have updated the translations assets (you do NOT need to provide translations)

    • Ran ./bin/makemessages_js.sh
    • Ran ./bin/compilemessages_js.sh
  • Dockerfile/scripts

    • Updated the Dockerfile with the necessary scripts from the ./bin folder
  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how

@robinmolen robinmolen linked an issue Feb 27, 2025 that may be closed by this pull request
11 tasks
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.67%. Comparing base (4b1ecdf) to head (c789e3c).
Report is 5 commits behind head on stable/3.0.x.

Additional details and impacted files
@@              Coverage Diff              @@
##           stable/3.0.x    #5128   +/-   ##
=============================================
  Coverage         96.67%   96.67%           
=============================================
  Files               762      762           
  Lines             26012    26012           
  Branches           3401     3401           
=============================================
  Hits              25148    25148           
  Misses              600      600           
  Partials            264      264           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

The PR for #4810 fixed an issue with the soft-required component being set to validate `required: true` (which locks a form, as the user cannot provide a value for the component).
As part of the patch release, we should provide users/admins/tech people an option that fixes the problem for all affected forms (besides "fix the JSON of all affected components manually").

This script sets the validation rule of `required` for all soft-required components to `false`. Fixing all form definitions affected by this bug
@robinmolen robinmolen merged commit 2df7c56 into stable/3.0.x Mar 3, 2025
29 checks passed
@robinmolen robinmolen deleted the release/3.0.5 branch March 3, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prepare patch releases
2 participants