Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#5107] Display referentielijsten options in component's preview #5144

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vaszig
Copy link
Contributor

@vaszig vaszig commented Mar 7, 2025

Closes #5107 partly

Changes

  • Added endpoint for retrieving the list of tabel items

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Problem detection in the admin email digest is handled
  • Release management

    • I have labelled the PR as "needs-backport" accordingly
  • I have updated the translations assets (you do NOT need to provide translations)

    • Ran ./bin/makemessages_js.sh
    • Ran ./bin/compilemessages_js.sh
  • Dockerfile/scripts

    • Updated the Dockerfile with the necessary scripts from the ./bin folder
  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how

@vaszig vaszig marked this pull request as draft March 7, 2025 13:43
@vaszig vaszig force-pushed the feature/5107-display-referentielijsten-items-as-options-in-the-component-preview branch from f18705e to bfdc8c7 Compare March 7, 2025 14:04
Copy link

codecov bot commented Mar 7, 2025

Codecov Report

Attention: Patch coverage is 96.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.74%. Comparing base (4657f86) to head (7d90997).
Report is 25 commits behind head on master.

Files with missing lines Patch % Lines
...forms/contrib/referentielijsten/api/serializers.py 90.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5144      +/-   ##
==========================================
- Coverage   96.75%   96.74%   -0.02%     
==========================================
  Files         778      779       +1     
  Lines       26741    26797      +56     
  Branches     3474     3487      +13     
==========================================
+ Hits        25873    25924      +51     
- Misses        606      607       +1     
- Partials      262      266       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vaszig vaszig force-pushed the feature/5107-display-referentielijsten-items-as-options-in-the-component-preview branch from bfdc8c7 to 6ef0910 Compare March 11, 2025 08:40
@vaszig vaszig force-pushed the feature/5107-display-referentielijsten-items-as-options-in-the-component-preview branch from 6ef0910 to 7d90997 Compare March 11, 2025 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Referentielijsten API: display items as options in component preview
1 participant