Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group variables by step #5146

Merged
merged 2 commits into from
Mar 11, 2025
Merged

Conversation

sergei-maertens
Copy link
Member

Closes clears up a post it on my desk - small quality of life update

Changes

  • Group variables by step in the variables editor
  • Removed the "form definition" column in variables table
  • Fixed storybook stories that were missing step context
  • Added code markup to variable key

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Problem detection in the admin email digest is handled
  • Release management

    • I have labelled the PR as "needs-backport" accordingly
  • I have updated the translations assets (you do NOT need to provide translations)

    • Ran ./bin/makemessages_js.sh
    • Ran ./bin/compilemessages_js.sh
  • Dockerfile/scripts

    • Updated the Dockerfile with the necessary scripts from the ./bin folder
  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how

Copy link

codecov bot commented Mar 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.74%. Comparing base (4cb4b65) to head (65a9ce5).
Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5146   +/-   ##
=======================================
  Coverage   96.74%   96.74%           
=======================================
  Files         779      779           
  Lines       26774    26774           
  Branches     3483     3483           
=======================================
  Hits        25903    25903           
  Misses        607      607           
  Partials      264      264           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@viktorvanwijk viktorvanwijk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Three minor things, and a general question: did you consider adding a fieldset for each step, instead of an extra row, like we do in the registration tab of the table? :)

@sergei-maertens
Copy link
Member Author

Three minor things, and a general question: did you consider adding a fieldset for each step, instead of an extra row, like we do in the registration tab of the table? :)

I think the extra blue borders create too much clutter, and more importantly, because the columns are sized by their content, their widths would not be consistent across steps and that makes it all look very janky. A single table forces identical column widths.

The component variables didn't correctly display the step that they
occur in.
The component variables are now grouped by the step they occur in, and
the column with the form definition name is removed. Variables are
sorted alphabetically, which should give a stable ordering of variables
inside of a step (or other tab). The steps are of course rendered in
order of definition.

The key of a component is now properly marked up as code, as it is a
system identifier and can help with quickly visual scanning which key
is required in logic rules.
@sergei-maertens sergei-maertens force-pushed the feature/group-variables-by-step branch from e98cee4 to 65a9ce5 Compare March 11, 2025 10:46
@sergei-maertens sergei-maertens merged commit 5c42863 into master Mar 11, 2025
33 checks passed
@sergei-maertens sergei-maertens deleted the feature/group-variables-by-step branch March 11, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants