-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Group variables by step #5146
Group variables by step #5146
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5146 +/- ##
=======================================
Coverage 96.74% 96.74%
=======================================
Files 779 779
Lines 26774 26774
Branches 3483 3483
=======================================
Hits 25903 25903
Misses 607 607
Partials 264 264 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Three minor things, and a general question: did you consider adding a fieldset for each step, instead of an extra row, like we do in the registration tab of the table? :)
src/openforms/js/components/admin/form_design/variables/VariablesTable.js
Outdated
Show resolved
Hide resolved
src/openforms/js/components/admin/form_design/variables/VariablesTable.js
Show resolved
Hide resolved
src/openforms/js/components/admin/form_design/variables/VariablesTable.js
Outdated
Show resolved
Hide resolved
I think the extra blue borders create too much clutter, and more importantly, because the columns are sized by their content, their widths would not be consistent across steps and that makes it all look very janky. A single table forces identical column widths. |
The component variables didn't correctly display the step that they occur in.
The component variables are now grouped by the step they occur in, and the column with the form definition name is removed. Variables are sorted alphabetically, which should give a stable ordering of variables inside of a step (or other tab). The steps are of course rendered in order of definition. The key of a component is now properly marked up as code, as it is a system identifier and can help with quickly visual scanning which key is required in logic rules.
e98cee4
to
65a9ce5
Compare
Closesclears up a post it on my desk - small quality of life updateChanges
code
markup to variable keyChecklist
Check off the items that are completed or not relevant.
Impact on features
Release management
I have updated the translations assets (you do NOT need to provide translations)
./bin/makemessages_js.sh
./bin/compilemessages_js.sh
Dockerfile/scripts
./bin
folderCommit hygiene