Skip to content

Commit a4140c0

Browse files
rhc54hppritcha
authored andcommitted
Remove the rtc framework
No longer any challengers to hwloc, so streamline the binding support by re-integrating it back into the odls framework. Signed-off-by: Ralph Castain <rhc@pmix.org> (cherry picked from commit add324c)
1 parent cafa80c commit a4140c0

24 files changed

+173
-1270
lines changed

contrib/scaling/scaling.pl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@
135135
push @starters, $starter;
136136
$opt = $starteroptionlist[$idx] . " --npernode " . $ppn;
137137
if ($multiplier gt 1) {
138-
$opt = $opt . " --mca rtc ^hwloc --mca ras_base_multiplier " . $multiplier;
138+
$opt = $opt . " --bind-to none --mca ras_base_multiplier " . $multiplier;
139139
}
140140
push @starteroptions, $opt;
141141
} elsif ($useaprun && $starter eq "aprun") {
@@ -294,7 +294,7 @@ ()
294294
if ($starter eq "prun") {
295295
my $dvm = "prte-dvm --system-server";
296296
if ($multiplier gt 1) {
297-
$dvm = $dvm . " --mca rtc ^hwloc --mca ras_base_multiplier " . $multiplier;
297+
$dvm = $dvm . " --bind-to none --mca ras_base_multiplier " . $multiplier;
298298
}
299299
# need to start it
300300
print "##DVM: Launching $dvm\n";

src/mca/ess/base/ess_base_std_prted.c

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,6 @@
5757
#include "src/mca/plm/base/base.h"
5858
#include "src/mca/prtereachable/base/base.h"
5959
#include "src/mca/rmaps/base/base.h"
60-
#include "src/mca/rtc/base/base.h"
6160
#include "src/mca/schizo/base/base.h"
6261
#include "src/mca/state/base/base.h"
6362
#include "src/mca/state/state.h"
@@ -405,19 +404,6 @@ int prte_ess_base_prted_setup(void)
405404
error = "prte_odls_base_select";
406405
goto error;
407406
}
408-
/* Open/select the rtc */
409-
if (PRTE_SUCCESS
410-
!= (ret = pmix_mca_base_framework_open(&prte_rtc_base_framework,
411-
PMIX_MCA_BASE_OPEN_DEFAULT))) {
412-
PRTE_ERROR_LOG(ret);
413-
error = "prte_rtc_base_open";
414-
goto error;
415-
}
416-
if (PRTE_SUCCESS != (ret = prte_rtc_base_select())) {
417-
PRTE_ERROR_LOG(ret);
418-
error = "prte_rtc_base_select";
419-
goto error;
420-
}
421407
if (PRTE_SUCCESS
422408
!= (ret = pmix_mca_base_framework_open(&prte_rmaps_base_framework,
423409
PMIX_MCA_BASE_OPEN_DEFAULT))) {
@@ -543,7 +529,6 @@ int prte_ess_base_prted_finalize(void)
543529
(void) pmix_mca_base_framework_close(&prte_plm_base_framework);
544530
/* make sure our local procs are dead */
545531
prte_odls.kill_local_procs(NULL);
546-
(void) pmix_mca_base_framework_close(&prte_rtc_base_framework);
547532
(void) pmix_mca_base_framework_close(&prte_odls_base_framework);
548533
(void) pmix_mca_base_framework_close(&prte_errmgr_base_framework);
549534
prte_rml_close();

src/mca/ess/hnp/ess_hnp_module.c

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,6 @@
6565
#include "src/mca/prtereachable/base/base.h"
6666
#include "src/mca/ras/base/base.h"
6767
#include "src/mca/rmaps/base/base.h"
68-
#include "src/mca/rtc/base/base.h"
6968
#include "src/mca/schizo/base/base.h"
7069
#include "src/mca/state/base/base.h"
7170
#include "src/mca/state/state.h"
@@ -406,19 +405,6 @@ static int rte_init(int argc, char **argv)
406405
error = "prte_odls_base_select";
407406
goto error;
408407
}
409-
/* Open/select the rtc */
410-
ret = pmix_mca_base_framework_open(&prte_rtc_base_framework,
411-
PMIX_MCA_BASE_OPEN_DEFAULT);
412-
if (PRTE_SUCCESS != ret) {
413-
PRTE_ERROR_LOG(ret);
414-
error = "prte_rtc_base_open";
415-
goto error;
416-
}
417-
if (PRTE_SUCCESS != (ret = prte_rtc_base_select())) {
418-
PRTE_ERROR_LOG(ret);
419-
error = "prte_rtc_base_select";
420-
goto error;
421-
}
422408

423409
/* set the pmix_output hnp file location to be in the
424410
* proc-specific session directory. */
@@ -483,7 +469,6 @@ static int rte_finalize(void)
483469
/* make sure our local procs are dead */
484470
prte_odls.kill_local_procs(NULL);
485471
}
486-
(void) pmix_mca_base_framework_close(&prte_rtc_base_framework);
487472
(void) pmix_mca_base_framework_close(&prte_odls_base_framework);
488473
prte_rml_close();
489474
(void) pmix_mca_base_framework_close(&prte_oob_base_framework);

src/mca/odls/base/Makefile.am

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
# All rights reserved
1414
# Copyright (c) 2019 Intel, Inc. All rights reserved.
1515
# Copyright (c) 2020 Cisco Systems, Inc. All rights reserved
16-
# Copyright (c) 2022 Nanook Consulting. All rights reserved.
16+
# Copyright (c) 2022-2024 Nanook Consulting All rights reserved.
1717
# $COPYRIGHT$
1818
#
1919
# Additional copyrights may follow
@@ -27,6 +27,7 @@ headers += \
2727
libprtemca_odls_la_SOURCES += \
2828
base/odls_base_frame.c \
2929
base/odls_base_select.c \
30-
base/odls_base_default_fns.c
30+
base/odls_base_default_fns.c \
31+
base/odls_base_bind.c
3132

3233
dist_prtedata_DATA += base/help-prte-odls-base.txt

src/mca/odls/base/base.h

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
* Copyright (c) 2011-2020 Cisco Systems, Inc. All rights reserved
1313
* Copyright (c) 2013 Los Alamos National Security, LLC. All rights reserved.
1414
* Copyright (c) 2017-2019 Intel, Inc. All rights reserved.
15-
* Copyright (c) 2021-2023 Nanook Consulting. All rights reserved.
15+
* Copyright (c) 2021-2024 Nanook Consulting All rights reserved.
1616
* $COPYRIGHT$
1717
*
1818
* Additional copyrights may follow
@@ -157,6 +157,10 @@ PRTE_EXPORT void prte_odls_base_start_threads(prte_job_t *jdata);
157157

158158
PRTE_EXPORT void prte_odls_base_harvest_threads(void);
159159

160+
/* Binding support */
161+
PRTE_EXPORT void prte_odls_base_set(prte_odls_spawn_caddy_t *cd, int write_fd);
162+
163+
160164
#define PRTE_ODLS_SET_ERROR(ns, s, j) \
161165
do { \
162166
int _idx; \

0 commit comments

Comments
 (0)