Skip to content

Commit f0d4efa

Browse files
authored
Merge pull request #41 from hppritcha/upstream_pr2028
Remove the rtc framework
2 parents 01103f1 + 45f9a60 commit f0d4efa

24 files changed

+173
-1270
lines changed

contrib/scaling/scaling.pl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@
135135
push @starters, $starter;
136136
$opt = $starteroptionlist[$idx] . " --npernode " . $ppn;
137137
if ($multiplier gt 1) {
138-
$opt = $opt . " --mca rtc ^hwloc --mca ras_base_multiplier " . $multiplier;
138+
$opt = $opt . " --bind-to none --mca ras_base_multiplier " . $multiplier;
139139
}
140140
push @starteroptions, $opt;
141141
} elsif ($useaprun && $starter eq "aprun") {
@@ -294,7 +294,7 @@ ()
294294
if ($starter eq "prun") {
295295
my $dvm = "prte-dvm --system-server";
296296
if ($multiplier gt 1) {
297-
$dvm = $dvm . " --mca rtc ^hwloc --mca ras_base_multiplier " . $multiplier;
297+
$dvm = $dvm . " --bind-to none --mca ras_base_multiplier " . $multiplier;
298298
}
299299
# need to start it
300300
print "##DVM: Launching $dvm\n";

src/mca/ess/base/ess_base_std_prted.c

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,6 @@
5656
#include "src/mca/plm/base/base.h"
5757
#include "src/mca/prtereachable/base/base.h"
5858
#include "src/mca/rmaps/base/base.h"
59-
#include "src/mca/rtc/base/base.h"
6059
#include "src/mca/schizo/base/base.h"
6160
#include "src/mca/state/base/base.h"
6261
#include "src/mca/state/state.h"
@@ -356,19 +355,6 @@ int prte_ess_base_prted_setup(void)
356355
error = "prte_odls_base_select";
357356
goto error;
358357
}
359-
/* Open/select the rtc */
360-
if (PRTE_SUCCESS
361-
!= (ret = pmix_mca_base_framework_open(&prte_rtc_base_framework,
362-
PMIX_MCA_BASE_OPEN_DEFAULT))) {
363-
PRTE_ERROR_LOG(ret);
364-
error = "prte_rtc_base_open";
365-
goto error;
366-
}
367-
if (PRTE_SUCCESS != (ret = prte_rtc_base_select())) {
368-
PRTE_ERROR_LOG(ret);
369-
error = "prte_rtc_base_select";
370-
goto error;
371-
}
372358
if (PRTE_SUCCESS
373359
!= (ret = pmix_mca_base_framework_open(&prte_rmaps_base_framework,
374360
PMIX_MCA_BASE_OPEN_DEFAULT))) {
@@ -494,7 +480,6 @@ int prte_ess_base_prted_finalize(void)
494480
(void) pmix_mca_base_framework_close(&prte_plm_base_framework);
495481
/* make sure our local procs are dead */
496482
prte_odls.kill_local_procs(NULL);
497-
(void) pmix_mca_base_framework_close(&prte_rtc_base_framework);
498483
(void) pmix_mca_base_framework_close(&prte_odls_base_framework);
499484
(void) pmix_mca_base_framework_close(&prte_errmgr_base_framework);
500485
prte_rml_close();

src/mca/ess/hnp/ess_hnp_module.c

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,6 @@
6464
#include "src/mca/prtereachable/base/base.h"
6565
#include "src/mca/ras/base/base.h"
6666
#include "src/mca/rmaps/base/base.h"
67-
#include "src/mca/rtc/base/base.h"
6867
#include "src/mca/schizo/base/base.h"
6968
#include "src/mca/state/base/base.h"
7069
#include "src/mca/state/state.h"
@@ -376,19 +375,6 @@ static int rte_init(int argc, char **argv)
376375
error = "prte_odls_base_select";
377376
goto error;
378377
}
379-
/* Open/select the rtc */
380-
ret = pmix_mca_base_framework_open(&prte_rtc_base_framework,
381-
PMIX_MCA_BASE_OPEN_DEFAULT);
382-
if (PRTE_SUCCESS != ret) {
383-
PRTE_ERROR_LOG(ret);
384-
error = "prte_rtc_base_open";
385-
goto error;
386-
}
387-
if (PRTE_SUCCESS != (ret = prte_rtc_base_select())) {
388-
PRTE_ERROR_LOG(ret);
389-
error = "prte_rtc_base_select";
390-
goto error;
391-
}
392378

393379
/* set the pmix_output hnp file location to be in the
394380
* proc-specific session directory. */
@@ -453,7 +439,6 @@ static int rte_finalize(void)
453439
/* make sure our local procs are dead */
454440
prte_odls.kill_local_procs(NULL);
455441
}
456-
(void) pmix_mca_base_framework_close(&prte_rtc_base_framework);
457442
(void) pmix_mca_base_framework_close(&prte_odls_base_framework);
458443
prte_rml_close();
459444
(void) pmix_mca_base_framework_close(&prte_prtereachable_base_framework);

src/mca/odls/base/Makefile.am

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
# All rights reserved
1414
# Copyright (c) 2019 Intel, Inc. All rights reserved.
1515
# Copyright (c) 2020 Cisco Systems, Inc. All rights reserved
16-
# Copyright (c) 2022 Nanook Consulting. All rights reserved.
16+
# Copyright (c) 2022-2024 Nanook Consulting All rights reserved.
1717
# $COPYRIGHT$
1818
#
1919
# Additional copyrights may follow
@@ -27,6 +27,7 @@ headers += \
2727
libprtemca_odls_la_SOURCES += \
2828
base/odls_base_frame.c \
2929
base/odls_base_select.c \
30-
base/odls_base_default_fns.c
30+
base/odls_base_default_fns.c \
31+
base/odls_base_bind.c
3132

3233
dist_prtedata_DATA += base/help-prte-odls-base.txt

src/mca/odls/base/base.h

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
* Copyright (c) 2011-2020 Cisco Systems, Inc. All rights reserved
1313
* Copyright (c) 2013 Los Alamos National Security, LLC. All rights reserved.
1414
* Copyright (c) 2017-2019 Intel, Inc. All rights reserved.
15-
* Copyright (c) 2021-2023 Nanook Consulting. All rights reserved.
15+
* Copyright (c) 2021-2024 Nanook Consulting All rights reserved.
1616
* $COPYRIGHT$
1717
*
1818
* Additional copyrights may follow
@@ -157,6 +157,10 @@ PRTE_EXPORT void prte_odls_base_start_threads(prte_job_t *jdata);
157157

158158
PRTE_EXPORT void prte_odls_base_harvest_threads(void);
159159

160+
/* Binding support */
161+
PRTE_EXPORT void prte_odls_base_set(prte_odls_spawn_caddy_t *cd, int write_fd);
162+
163+
160164
#define PRTE_ODLS_SET_ERROR(ns, s, j) \
161165
do { \
162166
int _idx; \

0 commit comments

Comments
 (0)