Skip to content

Removed mpich and slurm components from schizo framework #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Removed mpich and slurm components from schizo framework #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c3b1ed7
Removed mpich and slurm components from schizo framework
Michael-uofl Oct 1, 2024
f28bfc1
Removed pcc and psched tools
Michael-uofl Oct 1, 2024
4917ae2
Removed references to pcc and psched from documentation and build files
Michael-uofl Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,10 +158,7 @@ src/tools/prun/prun
src/tools/prte_info/prte_info
src/tools/prted/prted
src/tools/prte/prte
src/tools/pcc/pcc
src/tools/pcc/pcc-wrapper-data.txt
src/tools/pterm/pterm
src/tools/psched/psched

src/util/hostfile/hostfile_lex.c
src/util/keyval/keyval_lex.c
Expand Down
4 changes: 1 addition & 3 deletions config/prte_config_files.m4
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,10 @@ AC_DEFUN([PRTE_CONFIG_FILES],[
src/etc/Makefile
src/util/Makefile
src/util/hostfile/Makefile
src/tools/pcc/Makefile
src/tools/prted/Makefile
src/tools/prun/Makefile
src/tools/prte_info/Makefile
src/tools/prte/Makefile
src/tools/pterm/Makefile
src/tools/psched/Makefile
])
])
])
1 change: 0 additions & 1 deletion docs/Makefile.am
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@ PRTE_MAN1 = \
prted.1 \
prterun.1 \
prun.1 \
psched.1 \
pterm.1

PRTE_MAN5 = \
Expand Down
1 change: 0 additions & 1 deletion docs/man/man1/index.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,4 @@ Commands (section 1)
prted.1.rst
prterun.1.rst
prun.1.rst
psched.1.rst
pterm.1.rst
189 changes: 0 additions & 189 deletions docs/man/man1/psched.1.rst
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion docs/news/news-v2.x.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ series, in reverse chronological order.
- Remove event header defines
- Minor cleanups and ensure no local IOF copy
when persistent
- change the pcc wrapper compiler to a symlink
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you want to remove this: this is a historical note of what happened in a specific Open MPI v2.x release.

to pmixcc
- Cleanup code a bit
- Select all adapters with IPv4 addresses within
Expand Down
18 changes: 1 addition & 17 deletions docs/resilience.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ Building your application

Compile your application as usual

#. using the provided ``pcc`` for pmix-based application;
#. using your ``mpicc`` for mpi-based application with a prte-based MPI (e.g., Open MPI).

Running your application
Expand Down Expand Up @@ -128,7 +127,7 @@ Testing
--prtemca prte_abort_on_non_zero_status 0 \
--debug-daemons

# using 'errmgr_detector_enable 1' choose enable the error detector.
# using 'errmgr_detector_enable 1' choose enable the error detector.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was there a reason for which whitespace change?


Config with ``--enable-debug``, ``--debug-daemons`` will give you lots of information.

Expand All @@ -145,9 +144,6 @@ Step 3: under example we have 2 test codes ``error_notify.c``,

.. code-block:: bash

# Compile the codes
pcc -g error_notify.c -o error_notify
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure the changes in this file are correct. Removing this line of text from the example documentation means that the docs no longer show the compilation step. That doesn't seem right.

(same for the other similar changes in this file)


# Run
prun --oversubscribe --merge-stderr-to-stdout \
--map-by node:DISPLAY:DISPLAYALLOC \
Expand All @@ -159,12 +155,6 @@ If use external pmix:

.. code-block:: bash

# Compile
pcc error_notify.c -o error_notify_1 \
-I/external_pmix_install_path/include \
-L/external_pmix_install_path/lib \
-lpmix

# Run
prun --oversubscribe -x LD_LIBRARY_PATH \
--merge-stderr-to-stdout \
Expand All @@ -177,12 +167,6 @@ Iif use external pmix:

.. code-block:: bash

# Compile
pcc daemon_error_notify.c -o daemon_error_notify_1 \
-I/external_pmix_install_path/include \
-L/external_pmix_install_path/lib \
-lpmix

# Run
prun --oversubscribe -x LD_LIBRARY_PATH \
--merge-stderr-to-stdout \
Expand Down
1 change: 0 additions & 1 deletion examples/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@

# Use the PRRTE-provided wrapper compiler

CC = pcc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know what removing this line does? It will definitely break the functionality of this Makefile.

This is probably worth talking about at the next meeting.


# Using -g is not necessary, but it is helpful for example programs,
# especially if users want to examine them with debuggers.
Expand Down
2 changes: 0 additions & 2 deletions examples/README
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,4 @@ been directed _not_ to return any collected data from calls to PMIx_Put.
dynamic.c:


The Makefile assumes that the pcc wrapper compiler is in your path.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that this statement should be removed.


Make today a PMIx day!
2 changes: 0 additions & 2 deletions src/docs/show-help-files/Makefile.am
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ RST_SOURCE_FILES = \
$(srcdir)/help-prted.rst \
$(srcdir)/help-prterun.rst \
$(srcdir)/help-prun.rst \
$(srcdir)/help-psched.rst \
$(srcdir)/help-pterm.rst \
$(srcdir)/help-cli.rst \
$(srcdir)/help-dash-host.rst \
Expand All @@ -60,7 +59,6 @@ ALL_TXT_BUILT = \
$(TXT_OUTDIR)/help-prted.txt \
$(TXT_OUTDIR)/help-prterun.txt \
$(TXT_OUTDIR)/help-prun.txt \
$(TXT_OUTDIR)/help-psched.txt \
$(TXT_OUTDIR)/help-pterm.txt \
$(TXT_OUTDIR)/help-cli.txt \
$(TXT_OUTDIR)/help-dash-host.txt \
Expand Down
Empty file removed src/mca/schizo/mpich/.prte_ignore
View file
Open in desktop
Empty file.
1 change: 0 additions & 1 deletion src/mca/schizo/mpich/.prte_unignore
View file
Open in desktop

This file was deleted.

41 changes: 0 additions & 41 deletions src/mca/schizo/mpich/Makefile.am
View file
Open in desktop

This file was deleted.

Loading
Loading