Fixed cert update race condition #342
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #342 +/- ##
==========================================
+ Coverage 57.16% 58.87% +1.70%
==========================================
Files 1 1
Lines 572 586 +14
==========================================
+ Hits 327 345 +18
+ Misses 181 178 -3
+ Partials 64 63 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
p-strusiewiczsurmacki-mobica
force-pushed
the
race-condition-fix
branch
from
d7b4e7b to
f433eba
Compare
ritazh
reviewed
Mar 20, 2025
enj
reviewed
Mar 24, 2025
pkg/rotator/rotator.go
Outdated
| // Continue with reconciliation | ||
| case <-r.certsNotMounted: | ||
| // Requeue with backoff strategy | ||
| return reconcile.Result{Requeue: true, RequeueAfter: 5 * time.Second}, errors.New("certs not mounted, retrying reconciliation") |
There was a problem hiding this comment.
In the <-r.certsNotMounted case I would return reconcile.Result{}, errors.New("certs not mounted, retrying reconciliation"). For completeness I would also check ctx.Done.
There was a problem hiding this comment.
I've added the check for ctx.Done.
Signed-off-by: Patryk Strusiewicz-Surmacki <patryk-pawel.strusiewicz-surmacki@external.telekom.de>
Co-authored-by: Rita Zhang <rita.z.zhang@gmail.com> Signed-off-by: Patryk Strusiewicz-Surmacki <137421299+p-strusiewiczsurmacki-mobica@users.noreply.github.com>
Signed-off-by: Patryk Strusiewicz-Surmacki <patryk-pawel.strusiewicz-surmacki@external.telekom.de>
Signed-off-by: Patryk Strusiewicz-Surmacki <patryk-pawel.strusiewicz-surmacki@external.telekom.de>
Signed-off-by: Patryk Strusiewicz-Surmacki <patryk-pawel.strusiewicz-surmacki@external.telekom.de>
p-strusiewiczsurmacki-mobica
force-pushed
the
race-condition-fix
branch
from
4081a8a to
17a8458
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix #341
It adds check for
certsMountedchannel in reconciliation loop, so reconciliation will only start if all the certs are ready and mounted. This suppresses the irrelevant errors emitted by controller-runtime due to reconciliation loop and runable accessing same secret concurrently.