Updating the ML-KEM for finalized codepoints #176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Harrison <aleharri@cisco.com>
alharrison
force-pushed
the
feature/final_mlkem_codepoints
branch
from
1035000 to
88c39f0
Compare
dstebila
approved these changes
May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small change updates the codepoints for the 512, 768, and 1024 variants for ml-kem to reflect the finalized registrations here: https://www.iana.org/assignments/ssh-parameters/ssh-parameters.xhtml#ssh-parameters-16
Testing
I believe I properly followed the method outlined in your contribution guidelines by starting with the template file. I have also made updates in the README to match the strings used now. I manually tested this with our implementation and ran regressions locally.
Please let me know if there is anything else that should be done for this update.